Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(98)

Issue 2126193002: Add trace event to V8 compiler API. (Closed)

Created:
4 years, 5 months ago by ulan
Modified:
4 years, 5 months ago
Reviewers:
Yang
CC:
v8-reviews_googlegroups.com, fmeawad
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Add trace event to V8 compiler API. BUG=chromium:626256 LOG=NO Committed: https://crrev.com/72a2e68694716b434a1a78517c537fea411a4c35 Cr-Commit-Position: refs/heads/master@{#37578}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M src/api.cc View 3 chunks +3 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
ulan
PTAL. I checked manually that all other compiler API function go through these functions.
4 years, 5 months ago (2016-07-07 09:48:19 UTC) #2
Yang
On 2016/07/07 09:48:19, ulan wrote: > PTAL. I checked manually that all other compiler API ...
4 years, 5 months ago (2016-07-07 09:50:26 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2126193002/1
4 years, 5 months ago (2016-07-07 09:53:36 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-07 10:30:56 UTC) #6
commit-bot: I haz the power
4 years, 5 months ago (2016-07-07 10:31:12 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/72a2e68694716b434a1a78517c537fea411a4c35
Cr-Commit-Position: refs/heads/master@{#37578}

Powered by Google App Engine
This is Rietveld 408576698