Revert of Fix initialization ordering in GLES2CmdDecoder.

Revert of Fix initialization ordering in GLES2CmdDecoder. (patchset #2 id:20001 of https://codereview.chromium.org/2105153002/ )

Reason for revert:
Appears to break GPU webkit tests on Mac and Linux. This revert is a bit speculative since there are like 4 more gpu-related patches in the blame list, but the error messages does mention gles2_cmd_decoder.cc, so picking this patch as the first victim. https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Mac10.9/builds/34148/steps/webkit_tests/logs/stdio
https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20ASAN/builds/24915

Original issue's description:
> Fix initialization ordering in GLES2CmdDecoder.
>
> The ContextGroup must be initialized before feature flag checks will work
> correctly.
>
> BUG=602484
> CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel
>
> Committed: https://crrev.com/477e47082e76afca7c2e656a0714ee24e67fb702
> Cr-Commit-Position: refs/heads/master@{#404019}

TBR=piman@chromium.org,erikchen@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=602484
Committed: https://crrev.com/39de5e1f08c3162866e42b8cf932fdef0237c92a
Cr-Commit-Position: refs/heads/master@{#404112}

[phoglund_chromium, 2016-07-07 09:23:30]

The CQ bit was checked by phoglund@chromium.org

[phoglund_chromium, 2016-07-07 09:23:30]

Created Revert of Fix initialization ordering in GLES2CmdDecoder.

[commit-bot: I haz the power, 2016-07-07 09:23:43]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-07 09:24:22]

Description was changed from

==========
Revert of Fix initialization ordering in GLES2CmdDecoder. (patchset #2 id:20001
of https://codereview.chromium.org/2105153002/ )

Reason for revert:
Appears to break GPU webkit tests on Mac and Linux. This revert is a bit
speculative since there are like 4 more gpu-related patches in the blame list,
but the error messages does mention gles2_cmd_decoder.cc, so picking this patch
as the first victim.
https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Mac10.9/builds...
https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20ASAN/b...

Original issue's description:
> Fix initialization ordering in GLES2CmdDecoder.
> 
> The ContextGroup must be initialized before feature flag checks will work
> correctly.
> 
> BUG=602484
>
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel
> 
> Committed: https://crrev.com/477e47082e76afca7c2e656a0714ee24e67fb702
> Cr-Commit-Position: refs/heads/master@{#404019}

TBR=piman@chromium.org,erikchen@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=602484
==========

to

==========
Revert of Fix initialization ordering in GLES2CmdDecoder. (patchset #2 id:20001
of https://codereview.chromium.org/2105153002/ )

Reason for revert:
Appears to break GPU webkit tests on Mac and Linux. This revert is a bit
speculative since there are like 4 more gpu-related patches in the blame list,
but the error messages does mention gles2_cmd_decoder.cc, so picking this patch
as the first victim.
https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Mac10.9/builds...
https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20ASAN/b...

Original issue's description:
> Fix initialization ordering in GLES2CmdDecoder.
> 
> The ContextGroup must be initialized before feature flag checks will work
> correctly.
> 
> BUG=602484
>
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel
> 
> Committed: https://crrev.com/477e47082e76afca7c2e656a0714ee24e67fb702
> Cr-Commit-Position: refs/heads/master@{#404019}

TBR=piman@chromium.org,erikchen@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=602484
==========

[commit-bot: I haz the power, 2016-07-07 09:24:23]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-07-07 09:27:12]

Description was changed from

==========
Revert of Fix initialization ordering in GLES2CmdDecoder. (patchset #2 id:20001
of https://codereview.chromium.org/2105153002/ )

Reason for revert:
Appears to break GPU webkit tests on Mac and Linux. This revert is a bit
speculative since there are like 4 more gpu-related patches in the blame list,
but the error messages does mention gles2_cmd_decoder.cc, so picking this patch
as the first victim.
https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Mac10.9/builds...
https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20ASAN/b...

Original issue's description:
> Fix initialization ordering in GLES2CmdDecoder.
> 
> The ContextGroup must be initialized before feature flag checks will work
> correctly.
> 
> BUG=602484
>
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel
> 
> Committed: https://crrev.com/477e47082e76afca7c2e656a0714ee24e67fb702
> Cr-Commit-Position: refs/heads/master@{#404019}

TBR=piman@chromium.org,erikchen@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=602484
==========

to

==========
Revert of Fix initialization ordering in GLES2CmdDecoder. (patchset #2 id:20001
of https://codereview.chromium.org/2105153002/ )

Reason for revert:
Appears to break GPU webkit tests on Mac and Linux. This revert is a bit
speculative since there are like 4 more gpu-related patches in the blame list,
but the error messages does mention gles2_cmd_decoder.cc, so picking this patch
as the first victim.
https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Mac10.9/builds...
https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20ASAN/b...

Original issue's description:
> Fix initialization ordering in GLES2CmdDecoder.
>
> The ContextGroup must be initialized before feature flag checks will work
> correctly.
>
> BUG=602484
>
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel
>
> Committed: https://crrev.com/477e47082e76afca7c2e656a0714ee24e67fb702
> Cr-Commit-Position: refs/heads/master@{#404019}

TBR=piman@chromium.org,erikchen@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=602484

Committed: https://crrev.com/39de5e1f08c3162866e42b8cf932fdef0237c92a
Cr-Commit-Position: refs/heads/master@{#404112}
==========

[commit-bot: I haz the power, 2016-07-07 09:27:12]

Patchset 1 (id:??) landed as
https://crrev.com/39de5e1f08c3162866e42b8cf932fdef0237c92a
Cr-Commit-Position: refs/heads/master@{#404112}

[phoglund_chromium, 2016-07-07 09:34:37]

I had to revert https://codereview.chromium.org/2112783002/ as well for other
reasons, so it's quite possible that's actually the culprit. I will try to
re-land this one later.

[phoglund_chromium, 2016-07-07 11:56:30]

On 2016/07/07 09:34:37, phoglund_chrome wrote:
> I had to revert https://codereview.chromium.org/2112783002/ as well for other
> reasons, so it's quite possible that's actually the culprit. I will try to
> re-land this one later.

It's quite possible this patch was innocent, but I want to get a green build off
of https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20ASAN
before I try re-landing this.

[phoglund_chromium, 2016-07-07 13:43:16]

Attempting re-land now

[phoglund_chromium, 2016-07-07 13:43:47]

A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2121293004/ by phoglund@chromium.org.

The reason for reverting is: This patch was probably innocent,
https://codereview.chromium.org/2112783002/ was probably guilty..