src/gpu/batches/GrDashLinePathRenderer.cpp - Issue 2126083002: Remove fColor from PathRenderer DrawPathArgs struct

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/gpu/batches/GrDashLinePathRenderer.cpp

Issue 2126083002: Remove fColor from PathRenderer DrawPathArgs struct (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: Remove unnecessary GrPaint::setColor calls Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/gpu/batches/GrDashLinePathRenderer.cpp

diff --git a/src/gpu/batches/GrDashLinePathRenderer.cpp b/src/gpu/batches/GrDashLinePathRenderer.cpp

index e7ef2402a9cc7f182d8e528022dacc8ea49290ac..d040e84695f7ec2e4871e814a5bb06359b85636b 100644

--- a/src/gpu/batches/GrDashLinePathRenderer.cpp

+++ b/src/gpu/batches/GrDashLinePathRenderer.cpp

@@ -38,7 +38,7 @@ bool GrDashLinePathRenderer::onDrawPath(const DrawPathArgs& args) {

}

SkPoint pts[2];

SkAssertResult(args.fShape->asLine(pts, nullptr));

- SkAutoTUnref<GrDrawBatch> batch(GrDashingEffect::CreateDashLineBatch(args.fColor,

+ SkAutoTUnref<GrDrawBatch> batch(GrDashingEffect::CreateDashLineBatch(args.fPaint->getColor(),

*args.fViewMatrix,

pts,

aaMode,