Avoid calling the builtin String.prototype.split in Intl

Avoid calling the builtin String.prototype.split in Intl

The Intl code previously called the initial value of String.prototype.split
for some internal operations. However, this did not have the intended effect
as Intl only needs to split strings by strings, but String.prototype.split
has integration with Symbol.split for RegExps.

This patch replaces the calls of StringSplit in the Intl implementation
with direct calls to the %StringSplit runtime function to avoid the issue.

R=yangguo@chromium.org
BUG=v8:5179
Committed: https://crrev.com/97e8046e444da3e7e4729aa1ee5a4f86d56f69d0
Cr-Commit-Position: refs/heads/master@{#37615}

[Dan Ehrenberg, 2016-07-06 22:27:17]

The CQ bit was checked by littledan@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-06 22:27:24]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-06 22:30:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-06 22:30:55]

Dry run: Try jobs failed on following builders:
  v8_presubmit on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/18876)

[Yang, 2016-07-07 09:13:01]

https://codereview.chromium.org/2126073002/diff/1/src/js/i18n.js
File src/js/i18n.js (right):

https://codereview.chromium.org/2126073002/diff/1/src/js/i18n.js#newcode131
src/js/i18n.js:131: limit = (IS_UNDEFINED(limit)) ? kMaxUint32 :
TO_UINT32(limit);
I don't think StringSplit is used with the optional limit argument at all in
this file.
Also, can we figure out whether TO_STRING is necessary at all? If not, we could
simply call %StringSplit at all call sites, or some form of
%StringSplit(TO_STRING(a), TO_STRING(b), kMaxUint32), instead of using %_Call.

[Dan Ehrenberg, 2016-07-07 17:50:32]

The CQ bit was checked by littledan@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-07 17:50:37]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Dan Ehrenberg, 2016-07-07 17:50:57]

Description was changed from

==========
Avoid calling the builtin String.prototype.split in Intl

The Intl code previously called the initial value of String.prototype.split
for some internal operations. However, this did not have the intended effect
as Intl only needs to split strings by strings, but String.prototype.split
has integration with Symbol.split for RegExps.

This patch replaces the calls of StringSplit in the Intl implementation
to use a special-case version just for strings.

R=yangguo@chromium.org
BUG=v8:5179
==========

to

==========
Avoid calling the builtin String.prototype.split in Intl

The Intl code previously called the initial value of String.prototype.split
for some internal operations. However, this did not have the intended effect
as Intl only needs to split strings by strings, but String.prototype.split
has integration with Symbol.split for RegExps.

This patch replaces the calls of StringSplit in the Intl implementation
with direct calls to the %StringSplit runtime function to avoid the issue.

R=yangguo@chromium.org
BUG=v8:5179
==========

[commit-bot: I haz the power, 2016-07-07 17:54:27]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-07 17:54:29]

Dry run: Try jobs failed on following builders:
  v8_presubmit on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/18964)

[Dan Ehrenberg, 2016-07-07 18:35:18]

The CQ bit was checked by littledan@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-07 18:35:20]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Dan Ehrenberg, 2016-07-07 18:35:42]

https://codereview.chromium.org/2126073002/diff/1/src/js/i18n.js
File src/js/i18n.js (right):

https://codereview.chromium.org/2126073002/diff/1/src/js/i18n.js#newcode131
src/js/i18n.js:131: limit = (IS_UNDEFINED(limit)) ? kMaxUint32 :
TO_UINT32(limit);
On 2016/07/07 at 09:13:01, Yang wrote:
> I don't think StringSplit is used with the optional limit argument at all in
this file.
> Also, can we figure out whether TO_STRING is necessary at all? If not, we
could simply call %StringSplit at all call sites, or some form of
%StringSplit(TO_STRING(a), TO_STRING(b), kMaxUint32), instead of using %_Call.

That's true; I don't see a real need to call TO_STRING at all, except as
defensive programming. I initially prototyped it with just calling %StringSplit
all over the place, but I was thinking we might want to limit the number of
callsites to a runtime function and reduce the number of variables changed in
this patch. The new version just calls %StringSplit.

[commit-bot: I haz the power, 2016-07-07 19:14:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-07 19:14:58]

Dry run: This issue passed the CQ dry run.

[Yang, 2016-07-08 08:42:30]

lgtm

[Dan Ehrenberg, 2016-07-08 16:48:27]

The CQ bit was checked by littledan@chromium.org

[commit-bot: I haz the power, 2016-07-08 16:48:30]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-08 16:50:09]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-07-08 16:53:17]

Description was changed from

==========
Avoid calling the builtin String.prototype.split in Intl

The Intl code previously called the initial value of String.prototype.split
for some internal operations. However, this did not have the intended effect
as Intl only needs to split strings by strings, but String.prototype.split
has integration with Symbol.split for RegExps.

This patch replaces the calls of StringSplit in the Intl implementation
with direct calls to the %StringSplit runtime function to avoid the issue.

R=yangguo@chromium.org
BUG=v8:5179
==========

to

==========
Avoid calling the builtin String.prototype.split in Intl

The Intl code previously called the initial value of String.prototype.split
for some internal operations. However, this did not have the intended effect
as Intl only needs to split strings by strings, but String.prototype.split
has integration with Symbol.split for RegExps.

This patch replaces the calls of StringSplit in the Intl implementation
with direct calls to the %StringSplit runtime function to avoid the issue.

R=yangguo@chromium.org
BUG=v8:5179

Committed: https://crrev.com/97e8046e444da3e7e4729aa1ee5a4f86d56f69d0
Cr-Commit-Position: refs/heads/master@{#37615}
==========

[commit-bot: I haz the power, 2016-07-08 16:53:18]

Patchset 3 (id:??) landed as
https://crrev.com/97e8046e444da3e7e4729aa1ee5a4f86d56f69d0
Cr-Commit-Position: refs/heads/master@{#37615}