Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(304)

Issue 2126043003: Refactor HTMLTreeBuilder/HTMLConstructionSite ctor (Closed)

Created:
4 years, 5 months ago by kouhei (in TOK)
Modified:
4 years, 5 months ago
CC:
chromium-reviews, blink-reviews, dglazkov+blink, blink-reviews-html_chromium.org, kinuko+watch, yosin
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Refactor HTMLTreeBuilder/HTMLConstructionSite ctor No behavioral change. - Avoid duplicate member init in HTMLConstructionSite c-tor. - Use Document& instead of Document* as the document can't be nullref - Clarify that HTMLTreeBuilder can be invoked for generic Document (with a fixme comment) BUG=None Committed: https://crrev.com/2c5c2129caf0015729996cee64edb5079a847273 Cr-Commit-Position: refs/heads/master@{#404615}

Patch Set 1 #

Patch Set 2 : test fix / rebase #

Patch Set 3 : rebase / add comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -57 lines) Patch
M third_party/WebKit/Source/core/html/parser/HTMLConstructionSite.h View 1 chunk +3 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/html/parser/HTMLConstructionSite.cpp View 1 chunk +10 lines, -11 lines 0 comments Download
M third_party/WebKit/Source/core/html/parser/HTMLDocumentParser.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/parser/HTMLTreeBuilder.h View 1 2 3 chunks +6 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/html/parser/HTMLTreeBuilder.cpp View 1 2 5 chunks +19 lines, -38 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
kouhei (in TOK)
4 years, 5 months ago (2016-07-11 05:57:02 UTC) #3
haraken
LGTM
4 years, 5 months ago (2016-07-11 05:58:36 UTC) #4
kouhei (in TOK)
+yosin FYI
4 years, 5 months ago (2016-07-11 06:01:32 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2126043003/40001
4 years, 5 months ago (2016-07-11 07:19:54 UTC) #7
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 5 months ago (2016-07-11 08:27:53 UTC) #9
commit-bot: I haz the power
4 years, 5 months ago (2016-07-11 08:31:07 UTC) #11
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/2c5c2129caf0015729996cee64edb5079a847273
Cr-Commit-Position: refs/heads/master@{#404615}

Powered by Google App Engine
This is Rietveld 408576698