Issue 2126033003: Revert of Revert "Fix masters_test presubmit_tests by using serialized sqlite access."

Issue 2126033003: Revert of Revert "Fix masters_test presubmit_tests by using serialized sqlite access." (Closed)

Created:
4 years, 5 months ago by ghost stip (do not use)

Modified:
4 years, 5 months ago

Reviewers:
dsansome

CC:
chromium-reviews, infra-reviews+build_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/tools/build.git@buildbot-retry-concurrent

Target Ref:
refs/heads/master

Project:
build

Visibility:
Public.

Revert of Revert "Fix masters_test presubmit_tests by using serialized sqlite access." (patchset #1 id:1 of https://codereview.chromium.org/2102003003/ ) Reason for revert: possible cause of https://bugs.chromium.org/p/chromium/issues/detail?id=626354 Original issue's description: > Revert 4e7e4672aae819f312c9691544652f251964007f to make multiple connections to sqlite databases again. > > This is safe after https://codereview.chromium.org/2103053002/ > > BUG=620572 > > Committed: https://chromium.googlesource.com/chromium/tools/build/+/312d2566bfcb38bcaa25e93c27d9d862d05c7a8a TBR=dsansome@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=620572 Committed: https://chromium.googlesource.com/chromium/tools/build/+/30c81b34a804043ae02f69a3066c8f410c5af7e2

Created: 4 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -1 line)			Patch
	M	third_party/buildbot_8_4p1/buildbot/db/enginestrategy.py	View		1 chunk	+5 lines, -0 lines	0 comments	Download
	M	third_party/buildbot_8_4p1/buildbot/master.py	View		1 chunk	+2 lines, -1 line	0 comments	Download

Total messages: 5 (2 generated)

ghost stip (do not use)

Created Revert of Revert "Fix masters_test presubmit_tests by using serialized sqlite access."

4 years, 5 months ago (2016-07-07 16:34:00 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2126033003/1

4 years, 5 months ago (2016-07-07 16:34:09 UTC) #3

commit-bot: I haz the power

4 years, 5 months ago (2016-07-07 16:37:23 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/tools/build/+/30c81b34a804043ae02f...