[mojo-edk] Pump incoming messages in some missing places

[mojo-edk] Pump incoming messages in some missing places

Calls AcceptIncomingMessages() in two places it was missing:
  - OnRequestPortMerge(), since Node::MergePorts is called
  - DropPeer(), since Node::LostConnectionToNode is called

BUG=612500
Committed: https://crrev.com/a68850cee9663b6295f565a45d830c5271090c69
Cr-Commit-Position: refs/heads/master@{#404211}

[Ken Rockot(use gerrit already), 2016-07-06 20:10:29]

rockot@chromium.org changed reviewers:
+ amistry@chromium.org

[Ken Rockot(use gerrit already), 2016-07-06 20:10:30]

An alternative to your ProcessIncomingMessages CL. WDYT?

[Ken Rockot(use gerrit already), 2016-07-06 20:15:53]

On 2016/07/06 at 20:10:30, Ken Rockot wrote:
> An alternative to your ProcessIncomingMessages CL. WDYT?

While I still think we should do this, on second thought I don't think it has
anything to do with our renderer hangs. Keep in mind the CL which caused
renderer hangs doesn't add any use of cross-process or even locally transferred
message pipes. It only uses local message pipes to signal across threads -
MojoCreateMessagePipe, MojoWriteMessage (never with any handles), MojoWait, and
MojoWatch.

[Anand Mistry (off Chromium), 2016-07-07 00:04:39]

On 2016/07/06 20:15:53, Ken Rockot wrote:
> On 2016/07/06 at 20:10:30, Ken Rockot wrote:
> > An alternative to your ProcessIncomingMessages CL. WDYT?
> 
> While I still think we should do this, on second thought I don't think it has
> anything to do with our renderer hangs. Keep in mind the CL which caused
> renderer hangs doesn't add any use of cross-process or even locally
transferred
> message pipes. It only uses local message pipes to signal across threads -
> MojoCreateMessagePipe, MojoWriteMessage (never with any handles), MojoWait,
and
> MojoWatch.

I don't think your CL is causing the hangs. I think it's exacerbating an
existing problem:
https://crash.corp.google.com/browse?q=OMIT%20RECORD%20IF%20SUM(thread.StackT...

[Anand Mistry (off Chromium), 2016-07-07 00:07:01]

lgtm

once the tests are fixed

https://codereview.chromium.org/2126033002/diff/1/mojo/edk/system/node_contro...
File mojo/edk/system/node_controller.cc (right):

https://codereview.chromium.org/2126033002/diff/1/mojo/edk/system/node_contro...
mojo/edk/system/node_controller.cc:745: if (bootstrap_parent_channel_ &&
parent_name_ != ports::kInvalidNodeName) {
Looks like you forgot to invert the second part of this condition.

[Ken Rockot(use gerrit already), 2016-07-07 13:17:00]

https://codereview.chromium.org/2126033002/diff/1/mojo/edk/system/node_contro...
File mojo/edk/system/node_controller.cc (right):

https://codereview.chromium.org/2126033002/diff/1/mojo/edk/system/node_contro...
mojo/edk/system/node_controller.cc:745: if (bootstrap_parent_channel_ &&
parent_name_ != ports::kInvalidNodeName) {
On 2016/07/07 at 00:07:01, Anand Mistry wrote:
> Looks like you forgot to invert the second part of this condition.

indeed, done

[Ken Rockot(use gerrit already), 2016-07-07 13:17:06]

The CQ bit was checked by rockot@chromium.org

[Ken Rockot(use gerrit already), 2016-07-07 13:17:07]

The patchset sent to the CQ was uploaded after l-g-t-m from amistry@chromium.org
Link to the patchset: https://codereview.chromium.org/2126033002/#ps20001
(title: "oops")

[commit-bot: I haz the power, 2016-07-07 13:17:12]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-07 19:31:01]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-07-07 19:31:11]

CQ bit was unchecked.

[commit-bot: I haz the power, 2016-07-07 19:33:38]

Description was changed from

==========
[mojo-edk] Pump incoming messages in some missing places

Calls AcceptIncomingMessages() in two places it was missing:
  - OnRequestPortMerge(), since Node::MergePorts is called
  - DropPeer(), since Node::LostConnectionToNode is called

BUG=612500
==========

to

==========
[mojo-edk] Pump incoming messages in some missing places

Calls AcceptIncomingMessages() in two places it was missing:
  - OnRequestPortMerge(), since Node::MergePorts is called
  - DropPeer(), since Node::LostConnectionToNode is called

BUG=612500

Committed: https://crrev.com/a68850cee9663b6295f565a45d830c5271090c69
Cr-Commit-Position: refs/heads/master@{#404211}
==========

[commit-bot: I haz the power, 2016-07-07 19:33:40]

Patchset 2 (id:??) landed as
https://crrev.com/a68850cee9663b6295f565a45d830c5271090c69
Cr-Commit-Position: refs/heads/master@{#404211}