Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(131)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 212603021: Remove PlatformFile from resource_loader_unittest (Closed)

Created:
6 years, 9 months ago by rvargas (doing something else)
Modified:
6 years, 8 months ago
Reviewers:
davidben
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, cbentzel+watch_chromium.org, jam
Visibility:
Public.

Description

Remove PlatformFile from resource_loader_unittest BUG=322664 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=261488

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -21 lines) Patch
M content/browser/loader/resource_loader_unittest.cc View 1 chunk +6 lines, -12 lines 0 comments Download
M net/base/mock_file_stream.h View 1 chunk +2 lines, -2 lines 0 comments Download
M net/base/mock_file_stream.cc View 2 chunks +4 lines, -7 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
rvargas (doing something else)
PTAL
6 years, 8 months ago (2014-04-02 17:31:43 UTC) #1
davidben
lgtm
6 years, 8 months ago (2014-04-02 17:59:09 UTC) #2
rvargas (doing something else)
The CQ bit was checked by rvargas@chromium.org
6 years, 8 months ago (2014-04-02 18:01:59 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rvargas@chromium.org/212603021/1
6 years, 8 months ago (2014-04-02 18:04:01 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-03 08:32:35 UTC) #5
commit-bot: I haz the power
Commit queue rejected this change because the description was changed between the time the change ...
6 years, 8 months ago (2014-04-03 08:32:35 UTC) #6
rvargas (doing something else)
The CQ bit was checked by rvargas@chromium.org
6 years, 8 months ago (2014-04-03 18:13:36 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rvargas@chromium.org/212603021/1
6 years, 8 months ago (2014-04-03 18:14:09 UTC) #8
commit-bot: I haz the power
6 years, 8 months ago (2014-04-03 18:34:02 UTC) #9
Message was sent while issue was closed. 
Change committed as 261488

Powered by Google App Engine
This is Rietveld 408576698