Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(485)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 212603020: Break extensions ProcessManager dependency on Runtime API (Closed)

Created:
6 years, 9 months ago by James Cook
Modified:
6 years, 8 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Visibility:
Public.

Description

Break extensions ProcessManager dependency on Runtime API * Introduce a ProcessManagerObserver * Make the Chrome extension RuntimeAPI implementation use it to send onStartup events. BUG=354552 TEST=browser_tests *Extension* Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=260478

Patch Set 1 #

Patch Set 2 : rebase (pm-observer) #

Patch Set 3 : rebase (pm-observer) #

Unified diffs Side-by-side diffs Delta from patch set Stats (+73 lines, -6 lines) Patch
M chrome/browser/extensions/api/runtime/runtime_api.h View 3 chunks +7 lines, -1 line 0 comments Download
M chrome/browser/extensions/api/runtime/runtime_api.cc View 3 chunks +24 lines, -2 lines 0 comments Download
M extensions/browser/process_manager.h View 4 chunks +8 lines, -0 lines 0 comments Download
M extensions/browser/process_manager.cc View 4 chunks +12 lines, -3 lines 0 comments Download
A extensions/browser/process_manager_observer.h View 1 chunk +21 lines, -0 lines 0 comments Download
M extensions/extensions.gyp View 1 2 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 35 (0 generated)
James Cook
yoz, PTAL I also have a version of this that uses ExtensionsBrowserClient to delegate out ...
6 years, 9 months ago (2014-03-27 23:06:41 UTC) #1
Yoyo Zhou
Wow, this is clean. LGTM.
6 years, 9 months ago (2014-03-27 23:10:51 UTC) #2
James Cook
"Wow, this is clean." <- Thanks! You just made my day. :-)
6 years, 9 months ago (2014-03-27 23:35:41 UTC) #3
James Cook
The CQ bit was checked by jamescook@chromium.org
6 years, 9 months ago (2014-03-27 23:52:50 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jamescook@chromium.org/212603020/20001
6 years, 9 months ago (2014-03-27 23:55:25 UTC) #5
James Cook
The CQ bit was unchecked by jamescook@chromium.org
6 years, 9 months ago (2014-03-28 16:29:10 UTC) #6
James Cook
The CQ bit was checked by jamescook@chromium.org
6 years, 9 months ago (2014-03-28 16:29:24 UTC) #7
Sergey Berezin
The CQ bit was unchecked by sergeyberezin@chromium.org
6 years, 9 months ago (2014-03-28 20:23:47 UTC) #8
Sergey Berezin
The CQ bit was checked by sergeyberezin@chromium.org
6 years, 9 months ago (2014-03-28 20:27:11 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jamescook@chromium.org/212603020/20001
6 years, 9 months ago (2014-03-28 20:29:20 UTC) #10
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-28 21:38:04 UTC) #11
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) aura_unittests, cacheinvalidation_unittests, cc_unittests, check_deps, check_deps2git, chrome_elf_unittests, ...
6 years, 9 months ago (2014-03-28 21:38:05 UTC) #12
James Cook
The CQ bit was checked by jamescook@chromium.org
6 years, 9 months ago (2014-03-28 21:53:53 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jamescook@chromium.org/212603020/40001
6 years, 9 months ago (2014-03-28 21:57:36 UTC) #14
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-28 22:26:15 UTC) #15
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on win_chromium_compile_dbg
6 years, 9 months ago (2014-03-28 22:26:15 UTC) #16
James Cook
The CQ bit was checked by jamescook@chromium.org
6 years, 9 months ago (2014-03-28 22:30:20 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jamescook@chromium.org/212603020/40001
6 years, 9 months ago (2014-03-28 22:48:49 UTC) #18
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-28 22:59:57 UTC) #19
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on linux_chromium_rel
6 years, 9 months ago (2014-03-28 22:59:58 UTC) #20
James Cook
The CQ bit was checked by jamescook@chromium.org
6 years, 9 months ago (2014-03-28 23:31:09 UTC) #21
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jamescook@chromium.org/212603020/40001
6 years, 9 months ago (2014-03-28 23:31:44 UTC) #22
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-29 00:11:26 UTC) #23
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on linux_chromium_chromeos_rel
6 years, 9 months ago (2014-03-29 00:11:26 UTC) #24
James Cook
The CQ bit was checked by jamescook@chromium.org
6 years, 8 months ago (2014-03-29 04:36:52 UTC) #25
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jamescook@chromium.org/212603020/40001
6 years, 8 months ago (2014-03-29 04:37:11 UTC) #26
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-03-29 05:28:05 UTC) #27
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) unit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=290839
6 years, 8 months ago (2014-03-29 05:28:05 UTC) #28
James Cook
The CQ bit was checked by jamescook@chromium.org
6 years, 8 months ago (2014-03-29 15:46:33 UTC) #29
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jamescook@chromium.org/212603020/40001
6 years, 8 months ago (2014-03-29 15:46:40 UTC) #30
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-03-29 17:14:51 UTC) #31
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on linux_chromium_chromeos_rel
6 years, 8 months ago (2014-03-29 17:14:51 UTC) #32
James Cook
The CQ bit was checked by jamescook@chromium.org
6 years, 8 months ago (2014-03-30 23:14:14 UTC) #33
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jamescook@chromium.org/212603020/40001
6 years, 8 months ago (2014-03-30 23:14:16 UTC) #34
commit-bot: I haz the power
6 years, 8 months ago (2014-03-31 00:51:29 UTC) #35
Message was sent while issue was closed. 
Change committed as 260478

Powered by Google App Engine
This is Rietveld 408576698