Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1314)

Issue 212603014: Inline internal getters for typed arrays & friends. (Closed)

Created:
6 years, 8 months ago by Dmitry Lomov (no reviews)
Modified:
6 years, 8 months ago
CC:
v8-dev
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Increase first page size of OLD_POINTER_SPACE #

Patch Set 3 : Fix ApiObjectGroupsCycleForScavenger test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+148 lines, -99 lines) Patch
M src/arraybuffer.js View 2 chunks +2 lines, -2 lines 0 comments Download
M src/hydrogen.cc View 1 1 chunk +52 lines, -0 lines 0 comments Download
M src/hydrogen-instructions.h View 1 chunk +5 lines, -0 lines 0 comments Download
M src/runtime.h View 1 2 chunks +6 lines, -8 lines 0 comments Download
M src/runtime.cc View 1 2 chunks +11 lines, -42 lines 0 comments Download
M src/spaces.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M src/typedarray.js View 8 chunks +64 lines, -44 lines 0 comments Download
M test/cctest/test-api.cc View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M test/mjsunit/harmony/typedarrays.js View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Dmitry Lomov (no reviews)
PTAL.
6 years, 8 months ago (2014-03-27 17:27:28 UTC) #1
Dmitry Lomov (no reviews)
6 years, 8 months ago (2014-03-27 17:41:56 UTC) #2
Yang
lgtm.
6 years, 8 months ago (2014-03-28 09:34:03 UTC) #3
Dmitry Lomov (no reviews)
Adding Hannes for space.cc change review
6 years, 8 months ago (2014-03-28 11:47:25 UTC) #4
Hannes Payer (out of office)
LGTM
6 years, 8 months ago (2014-03-28 11:51:23 UTC) #5
Dmitry Lomov (no reviews)
Committed patchset #2 manually as r20330 (presubmit successful).
6 years, 8 months ago (2014-03-28 12:03:02 UTC) #6
Dmitry Lomov (no reviews)
6 years, 8 months ago (2014-03-28 15:25:42 UTC) #7
Message was sent while issue was closed.
Committed patchset #3 manually as r20338 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698