Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(715)

Unified Diff: src/handles-inl.h

Issue 212603013: Fix TSAN issue wrt assertions in the optimizing compiler thread. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: addressed comments Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | src/hydrogen-environment-liveness.h » ('j') | src/hydrogen-environment-liveness.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/handles-inl.h
diff --git a/src/handles-inl.h b/src/handles-inl.h
index a25b4a2266c6e19cb939b3270e9a9f38faeb6649..79ab4fdf3dfa710eddf003e61209e64b3d196aca 100644
--- a/src/handles-inl.h
+++ b/src/handles-inl.h
@@ -54,11 +54,11 @@ Handle<T>::Handle(T* obj, Isolate* isolate) {
template <typename T>
inline bool Handle<T>::is_identical_to(const Handle<T> other) const {
ASSERT(location_ == NULL || !(*location_)->IsFailure());
- if (location_ == other.location_) return true;
- if (location_ == NULL || other.location_ == NULL) return false;
// Dereferencing deferred handles to check object equality is safe.
SLOW_ASSERT(IsDereferenceAllowed(NO_DEFERRED_CHECK) &&
other.IsDereferenceAllowed(NO_DEFERRED_CHECK));
+ if (location_ == other.location_) return true;
+ if (location_ == NULL || other.location_ == NULL) return false;
return *location_ == *other.location_;
}
« no previous file with comments | « no previous file | src/hydrogen-environment-liveness.h » ('j') | src/hydrogen-environment-liveness.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698