Fix TSAN issue wrt assertions in the optimizing compiler thread.

src/handles-inl.h

Index: src/handles-inl.h
diff --git a/src/handles-inl.h b/src/handles-inl.h
index a25b4a2266c6e19cb939b3270e9a9f38faeb6649..79ab4fdf3dfa710eddf003e61209e64b3d196aca 100644
--- a/src/handles-inl.h
+++ b/src/handles-inl.h
@@ -54,11 +54,11 @@ Handle<T>::Handle(T* obj, Isolate* isolate) {
 template <typename T>
 inline bool Handle<T>::is_identical_to(const Handle<T> other) const {
   ASSERT(location_ == NULL || !(*location_)->IsFailure());
-  if (location_ == other.location_) return true;
-  if (location_ == NULL || other.location_ == NULL) return false;
   // Dereferencing deferred handles to check object equality is safe.
   SLOW_ASSERT(IsDereferenceAllowed(NO_DEFERRED_CHECK) &&
               other.IsDereferenceAllowed(NO_DEFERRED_CHECK));
+  if (location_ == other.location_) return true;
+  if (location_ == NULL || other.location_ == NULL) return false;

[Hannes Payer (out of office), 2014/03/27 17:16:20]

I guess you moved that code to have the asserts in the beginning of the
function?

[Yang, 2014/03/28 08:27:40]

Yes. This is to tighten the assertion.

   return *location_ == *other.location_;
 }