Fix TSAN issue wrt assertions in the optimizing compiler thread.

src/hydrogen-environment-liveness.cc

 // Copyright 2013 the V8 project authors. All rights reserved.
 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions are
 // met:
 //
 //     * Redistributions of source code must retain the above copyright
 //       notice, this list of conditions and the following disclaimer.
 //     * Redistributions in binary form must reproduce the above
 //       copyright notice, this list of conditions and the following
 //       disclaimer in the documentation and/or other materials provided
@@ skipping 66 matching lines @@
     BitVector* live_in_successor = live_at_block_start_[successor_id];
     if (live_in_successor->Equals(*live)) continue;
     for (int i = 0; i < live->length(); ++i) {
       if (!live->Contains(i)) continue;
       if (live_in_successor->Contains(i)) continue;
       if (first_simulate_invalid_for_index_.at(successor_id)->Contains(i)) {
         continue;
       }
       HSimulate* simulate = first_simulate_.at(successor_id);
       if (simulate == NULL) continue;
-      ASSERT(simulate->closure().is_identical_to(
-                 block->last_environment()->closure()));
+      { AllowHandleDereference locked;
+        ASSERT(simulate->closure().is_identical_to(
+                   block->last_environment()->closure()));
+      }
       ZapEnvironmentSlot(i, simulate);
     }
   }
 }
 
 
 void HEnvironmentLivenessAnalysisPhase::ZapEnvironmentSlotsForInstruction(
     HEnvironmentMarker* marker) {
   if (!marker->CheckFlag(HValue::kEndsLiveRange)) return;
   HSimulate* simulate = marker->next_simulate();
   if (simulate != NULL) {
-    ASSERT(simulate->closure().is_identical_to(marker->closure()));
+    { AllowHandleDereference locked;
+      ASSERT(simulate->closure().is_identical_to(marker->closure()));
+    }
     ZapEnvironmentSlot(marker->index(), simulate);
   }
 }
 
 
 void HEnvironmentLivenessAnalysisPhase::UpdateLivenessAtBlockEnd(
     HBasicBlock* block,
     BitVector* live) {
   // Liveness at the end of each block: union of liveness in successors.
   live->Clear();
@@ skipping 109 matching lines @@
           worklist.Add(block->inlined_entry_block()->block_id());
         }
       }
     }
     // Only collect bind/lookup instructions during the first pass.
     collect_markers_ = false;
   }
 
   // Analysis finished. Zap dead environment slots.
   for (int i = 0; i < markers_.length(); ++i) {
+    // Acquire relocation lock to dereference for assertion.
+#ifdef DEBUG
+    Heap::RelocationLock for_heap_access(isolate()->heap());

[Hannes Payer (out of office), 2014/03/27 17:16:20]

what about moving that locking code to where it is needed, i.e.
ZapEnvironmentSlotsForInstruction?

[Yang, 2014/03/28 08:27:40]

I refactored the handle comparison.

+#endif
     ZapEnvironmentSlotsForInstruction(markers_[i]);
   }
   for (int block_id = block_count_ - 1; block_id >= 0; --block_id) {
     HBasicBlock* block = graph()->blocks()->at(block_id);
     UpdateLivenessAtBlockEnd(block, &live);
+#ifdef DEBUG
+    Heap::RelocationLock for_heap_access(isolate()->heap());

[Hannes Payer (out of office), 2014/03/27 17:16:20]

what about moving that locking code to where it is needed, i.e.
ZapEnvironmentSlotsInSuccessors?

+#endif
     ZapEnvironmentSlotsInSuccessors(block, &live);
   }
 
   // Finally, remove the HEnvironment{Bind,Lookup} markers.
   for (int i = 0; i < markers_.length(); ++i) {
     markers_[i]->DeleteAndReplaceWith(NULL);
   }
 }
 
 } }  // namespace v8::internal