Newly created profiles should have the grey silhouette as avatar.

chrome/browser/profiles/profile_shortcut_manager_win.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/profiles/profile_shortcut_manager_win.h"
 
 #include <shlobj.h>  // For SHChangeNotify().
 
 #include <string>
 #include <vector>
@@ skipping 85 matching lines @@
   IDR_PROFILE_AVATAR_2X_16,
   IDR_PROFILE_AVATAR_2X_17,
   IDR_PROFILE_AVATAR_2X_18,
   IDR_PROFILE_AVATAR_2X_19,
   IDR_PROFILE_AVATAR_2X_20,
   IDR_PROFILE_AVATAR_2X_21,
   IDR_PROFILE_AVATAR_2X_22,
   IDR_PROFILE_AVATAR_2X_23,
   IDR_PROFILE_AVATAR_2X_24,
   IDR_PROFILE_AVATAR_2X_25,
+  IDR_PROFILE_AVATAR_2X_26,
 };
 
 // Badges |app_icon_bitmap| with |avatar_bitmap| at the bottom right corner and
 // returns the resulting SkBitmap.
 SkBitmap BadgeIcon(const SkBitmap& app_icon_bitmap,
                    const SkBitmap& avatar_bitmap,
                    int scale_factor) {
   // TODO(rlp): Share this chunk of code with
   // avatar_menu_button::DrawTaskBarDecoration.
   SkBitmap source_bitmap = avatar_bitmap;
   if ((avatar_bitmap.width() == scale_factor * profiles::kAvatarIconWidth) &&
       (avatar_bitmap.height() == scale_factor * profiles::kAvatarIconHeight)) {
     // Shave a couple of columns so the bitmap is more square. So when
     // resized to a square aspect ratio it looks pretty.
     gfx::Rect frame(scale_factor * profiles::kAvatarIconWidth,
                     scale_factor * profiles::kAvatarIconHeight);
     frame.Inset(scale_factor * 2, 0, scale_factor * 2, 0);
     avatar_bitmap.extractSubset(&source_bitmap, gfx::RectToSkIRect(frame));
   } else {
-    NOTREACHED();
+    // Square bitmaps are valid, nothing else should occur.
+    if (avatar_bitmap.width() != avatar_bitmap.height()) {

[noms (inactive), 2014/03/27 20:39:53]

nit: no brackets.
Also: as discussed offline, I don't think this works for the placeholder avatar,
as I think we should execute the code above in that case as well.

[Mike Lerman, 2014/04/02 17:46:25]

Nit - Done.

Offline discussion - the problem we found is caused elsewhere
(ProfileListDesktop::RebuildMenu). I will check a solution in with this CL.

On 2014/03/27 20:39:53, Monica Dinculescu wrote:

+      NOTREACHED();
+    }
   }
   int avatar_badge_size = kProfileAvatarBadgeSize;
   if (app_icon_bitmap.width() != kShortcutIconSize) {
     avatar_badge_size =
         app_icon_bitmap.width() * kProfileAvatarBadgeSize / kShortcutIconSize;
   }
   SkBitmap sk_icon = skia::ImageOperations::Resize(
       source_bitmap, skia::ImageOperations::RESIZE_LANCZOS3, avatar_badge_size,
       source_bitmap.height() * avatar_badge_size / source_bitmap.width());
 
@@ skipping 716 matching lines @@
         // Ensure the profile's icon file has been created.
         CreateOrUpdateProfileIcon(profile->GetPath());
       }
       break;
     }
     default:
       NOTREACHED();
       break;
   }
 }