Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3200)

Unified Diff: chrome/browser/ui/webui/sync_internals_message_handler.cc

Issue 212603007: sync: Buffer Protocol Events for about:sync page (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Rebase Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/webui/sync_internals_message_handler.h ('k') | sync/internal_api/protocol_event_buffer.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/webui/sync_internals_message_handler.cc
diff --git a/chrome/browser/ui/webui/sync_internals_message_handler.cc b/chrome/browser/ui/webui/sync_internals_message_handler.cc
index e0b64f9bf081ee10a2ee0ae98086bcf11b3dab83..3896a429ef70778f66cac42815285caa5b161dae 100644
--- a/chrome/browser/ui/webui/sync_internals_message_handler.cc
+++ b/chrome/browser/ui/webui/sync_internals_message_handler.cc
@@ -41,14 +41,10 @@ SyncInternalsMessageHandler::~SyncInternalsMessageHandler() {
void SyncInternalsMessageHandler::RegisterMessages() {
DCHECK(content::BrowserThread::CurrentlyOn(content::BrowserThread::UI));
- // Register for ProfileSyncService events.
- ProfileSyncService* service = GetProfileSyncService();
- if (service) {
- service->AddObserver(this);
- service->AddProtocolEventObserver(this);
- js_controller_ = service->GetJsController();
- js_controller_->AddJsEventHandler(this);
- }
+ web_ui()->RegisterMessageCallback(
+ "registerForEvents",
+ base::Bind(&SyncInternalsMessageHandler::HandleRegisterForEvents,
+ base::Unretained(this)));
web_ui()->RegisterMessageCallback(
"requestUpdatedAboutInfo",
@@ -64,6 +60,19 @@ void SyncInternalsMessageHandler::RegisterMessages() {
RegisterJsControllerCallback("getClientServerTraffic");
}
+void SyncInternalsMessageHandler::HandleRegisterForEvents(
+ const base::ListValue* args) {
+ DCHECK(args->empty());
+
+ ProfileSyncService* service = GetProfileSyncService();
+ if (service) {
+ service->AddObserver(this);
+ service->AddProtocolEventObserver(this);
+ js_controller_ = service->GetJsController();
+ js_controller_->AddJsEventHandler(this);
+ }
+}
+
void SyncInternalsMessageHandler::HandleRequestUpdatedAboutInfo(
const base::ListValue* args) {
DCHECK(args->empty());
« no previous file with comments | « chrome/browser/ui/webui/sync_internals_message_handler.h ('k') | sync/internal_api/protocol_event_buffer.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698