Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1068)

Unified Diff: content/browser/gpu/gpu_ipc_browsertests.cc

Issue 212603006: Remove the kDisableGpuProcessPrelaunch flag and disable tests. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/gpu/gpu_ipc_browsertests.cc
diff --git a/content/browser/gpu/gpu_ipc_browsertests.cc b/content/browser/gpu/gpu_ipc_browsertests.cc
index e4173756b1c8864b0cf390194f69a92175a1fe08..2a76287d1c6a4f60f6fb71f4f1e90f9585424671 100644
--- a/content/browser/gpu/gpu_ipc_browsertests.cc
+++ b/content/browser/gpu/gpu_ipc_browsertests.cc
@@ -69,7 +69,7 @@ class ContextTestBase : public content::ContentBrowserTest {
namespace content {
-class BrowserGpuChannelHostFactoryTest : public ContextTestBase {
+class BrowserGpuChannelHostFactoryTest : public ContentBrowserTest {
public:
virtual void SetUpOnMainThread() OVERRIDE {
if (!BrowserGpuChannelHostFactory::CanUseForTesting())
@@ -85,16 +85,6 @@ class BrowserGpuChannelHostFactoryTest : public ContextTestBase {
ContentBrowserTest::SetUpOnMainThread();
}
- virtual void TearDownOnMainThread() OVERRIDE {
- ContextTestBase::TearDownOnMainThread();
- }
-
- virtual void SetUpCommandLine(CommandLine* command_line) OVERRIDE {
- // Start all tests without a gpu channel so that the tests exercise a
- // consistent codepath.
- command_line->AppendSwitch(switches::kDisableGpuProcessPrelaunch);
- }
-
void OnContextLost(const base::Closure callback, int* counter) {
(*counter)++;
callback.Run();
@@ -135,20 +125,16 @@ class BrowserGpuChannelHostFactoryTest : public ContextTestBase {
}
};
-IN_PROC_BROWSER_TEST_F(BrowserGpuChannelHostFactoryTest, Basic) {
- if (!context_)
- return;
-
+// Fails since UI Compositor establishes a GpuChannel.
+IN_PROC_BROWSER_TEST_F(BrowserGpuChannelHostFactoryTest, DISABLED_Basic) {
DCHECK(!IsChannelEstablished());
EstablishAndWait();
EXPECT_TRUE(GetGpuChannel() != NULL);
}
+// Fails since UI Compositor establishes a GpuChannel.
IN_PROC_BROWSER_TEST_F(BrowserGpuChannelHostFactoryTest,
- EstablishAndTerminate) {
- if (!context_)
- return;
-
+ DISABLED_EstablishAndTerminate) {
DCHECK(!IsChannelEstablished());
base::RunLoop run_loop;
GetFactory()->EstablishGpuChannel(kInitCause, run_loop.QuitClosure());
@@ -158,10 +144,9 @@ IN_PROC_BROWSER_TEST_F(BrowserGpuChannelHostFactoryTest,
run_loop.Run();
}
-IN_PROC_BROWSER_TEST_F(BrowserGpuChannelHostFactoryTest, AlreadyEstablished) {
- if (!context_)
- return;
-
+// Fails since UI Compositor establishes a GpuChannel.
+IN_PROC_BROWSER_TEST_F(BrowserGpuChannelHostFactoryTest,
+ DISABLED_AlreadyEstablished) {
DCHECK(!IsChannelEstablished());
scoped_refptr<GpuChannelHost> gpu_channel =
GetFactory()->EstablishGpuChannelSync(kInitCause);
@@ -175,10 +160,9 @@ IN_PROC_BROWSER_TEST_F(BrowserGpuChannelHostFactoryTest, AlreadyEstablished) {
EXPECT_EQ(gpu_channel, GetGpuChannel());
}
-IN_PROC_BROWSER_TEST_F(BrowserGpuChannelHostFactoryTest, CrashAndRecover) {
- if (!context_)
- return;
-
+// Fails since UI Compositor establishes a GpuChannel.
+IN_PROC_BROWSER_TEST_F(BrowserGpuChannelHostFactoryTest,
+ DISABLED_CrashAndRecover) {
DCHECK(!IsChannelEstablished());
EstablishAndWait();
scoped_refptr<GpuChannelHost> host = GetGpuChannel();

Powered by Google App Engine
This is Rietveld 408576698