De-bloat SVGPathStringBuilder

Source/wtf/text/StringBuilder.cpp

 /*
  * Copyright (C) 2010 Apple Inc. All rights reserved.
  * Copyright (C) 2012 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  * 1. Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
  * 2. Redistributions in binary form must reproduce the above copyright
@@ skipping 11 matching lines @@
  * OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
  * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
  * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
  */
 
 #include "config.h"
 #include "StringBuilder.h"
 
 #include "IntegerToStringConversion.h"
 #include "WTFString.h"
+#include "wtf/dtoa.h"
 
 namespace WTF {
 
 static unsigned expandedCapacity(unsigned capacity, unsigned requiredLength)
 {
     static const unsigned minimumCapacity = 16;
     return std::max(requiredLength, std::max(minimumCapacity, capacity * 2));
 }
 
 void StringBuilder::reifyString()
@@ skipping 297 matching lines @@
 void StringBuilder::appendNumber(long long number)
 {
     numberToStringSigned<StringBuilder>(number, this);
 }
 
 void StringBuilder::appendNumber(unsigned long long number)
 {
     numberToStringUnsigned<StringBuilder>(number, this);
 }
 
+static void expandLCharToUCharInplace(UChar* buffer, size_t length)
+{
+    const LChar* sourceEnd = reinterpret_cast<LChar*>(buffer) + length;
+    UChar* current = buffer + length;
+    while (current != buffer)
+        *--current = *--sourceEnd;
+    ASSERT(current == buffer);

[abarth-chromium, 2014/03/28 17:41:43]

This ASSERT seems unnecessary.  That's the only way to exit the loop.

[fs, 2014/03/31 07:41:56]

Dropped.

+}
+
+void StringBuilder::appendNumber(double number, unsigned precision, TrailingZerosTruncatingPolicy trailingZerosTruncatingPolicy)
+{
+    bool truncateTrailingZeros = trailingZerosTruncatingPolicy == TruncateTrailingZeros;
+    size_t numberLength;
+    if (m_is8Bit) {
+        LChar* dest = appendUninitialized<LChar>(NumberToStringBufferLength);
+        const char* result = numberToFixedPrecisionString(number, precision, reinterpret_cast<char*>(dest), truncateTrailingZeros);
+        numberLength = strlen(result);
+    } else {
+        UChar* dest = appendUninitialized<UChar>(NumberToStringBufferLength);
+        const char* result = numberToFixedPrecisionString(number, precision, reinterpret_cast<char*>(dest), truncateTrailingZeros);
+        numberLength = strlen(result);
+        expandLCharToUCharInplace(dest, numberLength);

[abarth-chromium, 2014/03/28 17:41:43]

Woah

+    }
+    ASSERT(m_length >= NumberToStringBufferLength);
+    // Remove what appendUninitialized added.
+    m_length -= NumberToStringBufferLength;
+    ASSERT(numberLength <= NumberToStringBufferLength);
+    m_length += numberLength;
+}
+
 bool StringBuilder::canShrink() const
 {
     // Only shrink the buffer if it's less than 80% full. Need to tune this heuristic!
     return m_buffer && m_buffer->length() > (m_length + (m_length >> 2));
 }
 
 void StringBuilder::shrinkToFit()
 {
     if (!canShrink())
         return;
     if (m_is8Bit)
         reallocateBuffer<LChar>(m_length);
     else
         reallocateBuffer<UChar>(m_length);
     m_string = m_buffer.release();
 }
 
 } // namespace WTF