Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(259)

Issue 212603002: RuleFeatures argument list cleanup. (Closed)

Created:
6 years, 9 months ago by rune
Modified:
6 years, 9 months ago
Reviewers:
chrishtr, esprehn
CC:
blink-reviews, ed+blinkwatch_opera.com, dglazkov+blink, apavlov+blink_chromium.org, darktears, rune+blink, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

RuleFeatures argument list cleanup. Got rid of extensive argument lists for invalidation set features by introducing a struct for them. R=esprehn@chromium.org,chrishtr@chromium.org BUG= Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=170101

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -25 lines) Patch
M Source/core/css/RuleFeature.h View 1 chunk +11 lines, -2 lines 0 comments Download
M Source/core/css/RuleFeature.cpp View 3 chunks +19 lines, -23 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
rune
6 years, 9 months ago (2014-03-26 10:09:16 UTC) #1
chrishtr
lgtm
6 years, 9 months ago (2014-03-26 16:27:02 UTC) #2
esprehn
lgtm
6 years, 9 months ago (2014-03-26 20:03:17 UTC) #3
esprehn
The CQ bit was checked by esprehn@chromium.org
6 years, 9 months ago (2014-03-26 20:03:20 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rune@opera.com/212603002/1
6 years, 9 months ago (2014-03-26 20:03:35 UTC) #5
commit-bot: I haz the power
6 years, 9 months ago (2014-03-26 21:12:17 UTC) #6
Message was sent while issue was closed.
Change committed as 170101

Powered by Google App Engine
This is Rietveld 408576698