Mac (Cocoa) Omnibox: Force text field to LTR context if it is a URL.

chrome/browser/ui/cocoa/omnibox/omnibox_view_mac.mm

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/cocoa/omnibox/omnibox_view_mac.h"
 
 #include <Carbon/Carbon.h>  // kVK_Return
 
 #include "base/mac/foundation_util.h"
 #include "base/memory/ptr_util.h"
@@ skipping 531 matching lines @@
     // that happens, |storage| and |field_| will not be synced automatically any
     // more. Calling -stringValue ensures that |field_| reflects the changes to
     // |storage|.
     [field_ stringValue];
   } else {
     SetText(GetText());
   }
 }
 
 void OmniboxViewMac::ApplyTextStyle(
+    bool force_ltr,
     NSMutableAttributedString* attributedString) {
   [attributedString addAttribute:NSFontAttributeName
                            value:GetNormalFieldFont()
                            range:NSMakeRange(0, [attributedString length])];
 
   // Make a paragraph style locking in the standard line height as the maximum,
   // otherwise the baseline may shift "downwards".
   base::scoped_nsobject<NSMutableParagraphStyle> paragraph_style(
       [[NSMutableParagraphStyle alloc] init]);
   CGFloat line_height = [[field_ cell] lineHeight];
   [paragraph_style setMaximumLineHeight:line_height];
   [paragraph_style setMinimumLineHeight:line_height];
   [paragraph_style setLineBreakMode:NSLineBreakByTruncatingTail];
+  if (force_ltr)

[tapted, 2016/07/21 04:37:05]

optional: I'd probably just use model()->CurrentTextIsURL() here, but this has
merit too

[Matt Giuca, 2016/07/21 04:55:37]

Done.

+    [paragraph_style setBaseWritingDirection:NSWritingDirectionLeftToRight];
   [attributedString addAttribute:NSParagraphStyleAttributeName
                            value:paragraph_style
                            range:NSMakeRange(0, [attributedString length])];
 }
 
 void OmniboxViewMac::ApplyTextAttributes(
     const base::string16& display_text,
     NSMutableAttributedString* attributedString) {
   NSUInteger as_length = [attributedString length];
   if (as_length == 0) {
     return;
   }
   NSRange as_entire_string = NSMakeRange(0, as_length);
   bool in_dark_mode = [[field_ window] inIncognitoModeWithSystemTheme];
+  // If this is a URL, set the top-level paragraph direction to LTR (avoids RTL
+  // characters from making the URL render from right to left, as per RFC 3987
+  // Section 4.1).
+  bool force_ltr = model()->CurrentTextIsURL();
 
-  ApplyTextStyle(attributedString);
+  ApplyTextStyle(force_ltr, attributedString);
 
   // A kinda hacky way to add breaking at periods. This is what Safari does.
   // This works for IDNs too, despite the "en_US".
   [attributedString addAttribute:@"NSLanguage"
                            value:@"en_US_POSIX"
                            range:as_entire_string];
 
   if (ui::MaterialDesignController::IsModeMaterial()) {
     [attributedString addAttribute:NSForegroundColorAttributeName
                              value:HostTextColor(in_dark_mode)
@@ skipping 566 matching lines @@
                               display_text);
   NSDictionary* notification_info = @{
       NSAccessibilityAnnouncementKey : announcement,
       NSAccessibilityPriorityKey :     @(NSAccessibilityPriorityHigh)
   };
   NSAccessibilityPostNotificationWithUserInfo(
       [field_ window],
       NSAccessibilityAnnouncementRequestedNotification,
       notification_info);
 }