Mac (Cocoa) Omnibox: Force text field to LTR context if it is a URL.

chrome/browser/ui/cocoa/omnibox/omnibox_popup_cell.mm

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #import "chrome/browser/ui/cocoa/omnibox/omnibox_popup_cell.h"
 
 #include <stddef.h>
 
 #include <algorithm>
 #include <cmath>
@@ skipping 134 matching lines @@
   // Calculate a slightly smaller font. The ratio here is somewhat arbitrary.
   // Proportions from 5/9 to 5/7 all look pretty good.
   CGFloat size = [font pointSize] * 5.0 / 9.0;
   NSFontDescriptor* descriptor = [font fontDescriptor];
   return [NSFont fontWithDescriptor:descriptor size:size];
 }
 NSFont* SmallFont() {
   return OmniboxViewMac::GetSmallFont();
 }
 
+// Sets the writing direction to |direction| for a given |range| of
+// |attributedString|.
+void SetTextDirectionForRange(NSMutableAttributedString* attributedString,
+                              NSWritingDirection direction,
+                              NSRange range) {
+  base::scoped_nsobject<NSMutableParagraphStyle> paragraph_style(
+      [[NSMutableParagraphStyle alloc] init]);
+  [paragraph_style setBaseWritingDirection:direction];
+  [attributedString addAttribute:NSParagraphStyleAttributeName
+                           value:paragraph_style
+                           range:range];
+}
+
 NSAttributedString* CreateAnswerStringHelper(const base::string16& text,
                                              NSInteger style_type,
                                              bool is_bold,
                                              BOOL is_dark_theme) {
   NSDictionary* answer_style = nil;
   NSFont* answer_font = nil;
   bool is_mode_material = ui::MaterialDesignController::IsModeMaterial();
   switch (style_type) {
     case SuggestionAnswer::TOP_ALIGNED:
       answer_style = @{
@@ skipping 191 matching lines @@
     const NSRange range =
         NSMakeRange(location, std::min(length, match_length - location));
 
     if (0 != (i->style & ACMatchClassification::MATCH)) {
       [attributedString addAttribute:NSFontAttributeName
                                value:BoldFieldFont()
                                range:range];
     }
 
     if (0 != (i->style & ACMatchClassification::URL)) {
+      // URLs have their text direction set to to LTR (avoids RTL characters
+      // making the URL render from right to left, as per RFC 3987 Section 4.1).
+      SetTextDirectionForRange(attributedString, NSWritingDirectionLeftToRight,
+                               range);
       [attributedString addAttribute:NSForegroundColorAttributeName
                                value:URLTextColor(is_dark_theme)
                                range:range];
     } else if (0 != (i->style & ACMatchClassification::DIM)) {
       [attributedString addAttribute:NSForegroundColorAttributeName
                                value:DimTextColor(is_dark_theme)
                                range:range];
     }
   }
 
@@ skipping 343 matching lines @@
   base::string16 raw_separator =
       l10n_util::GetStringUTF16(IDS_AUTOCOMPLETE_MATCH_DESCRIPTION_SEPARATOR);
   return CreateAttributedString(raw_separator, DimTextColor(isDarkTheme));
 }
 
 + (CGFloat)getContentAreaWidth:(NSRect)cellFrame {
   return NSWidth(cellFrame) - TextStartOffset();
 }
 
 @end