Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(249)

Unified Diff: net/tools/quic/test_tools/quic_test_client.cc

Issue 2126023002: use std::unique_ptr for the callback argument of QUIC's ProofVerifier::Verify proof to make ownersh… (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@126327823
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/tools/quic/test_tools/quic_test_client.cc
diff --git a/net/tools/quic/test_tools/quic_test_client.cc b/net/tools/quic/test_tools/quic_test_client.cc
index 914c4f8ab03f15d9597bd7c916c18f38a3e893fc..651adf8c30955ed620d2cf0be0b4740d8c7e16eb 100644
--- a/net/tools/quic/test_tools/quic_test_client.cc
+++ b/net/tools/quic/test_tools/quic_test_client.cc
@@ -45,18 +45,19 @@ namespace {
class RecordingProofVerifier : public ProofVerifier {
public:
// ProofVerifier interface.
- QuicAsyncStatus VerifyProof(const string& hostname,
- const uint16_t port,
- const string& server_config,
- QuicVersion quic_version,
- StringPiece chlo_hash,
- const vector<string>& certs,
- const string& cert_sct,
- const string& signature,
- const ProofVerifyContext* context,
- string* error_details,
- std::unique_ptr<ProofVerifyDetails>* details,
- ProofVerifierCallback* callback) override {
+ QuicAsyncStatus VerifyProof(
+ const string& hostname,
+ const uint16_t port,
+ const string& server_config,
+ QuicVersion quic_version,
+ StringPiece chlo_hash,
+ const vector<string>& certs,
+ const string& cert_sct,
+ const string& signature,
+ const ProofVerifyContext* context,
+ string* error_details,
+ std::unique_ptr<ProofVerifyDetails>* details,
+ std::unique_ptr<ProofVerifierCallback> callback) override {
common_name_.clear();
if (certs.empty()) {
return QUIC_FAILURE;
« net/quic/crypto/proof_verifier_chromium.cc ('K') | « net/quic/quic_crypto_client_stream.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698