Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(519)

Unified Diff: net/quic/crypto/crypto_server_test.cc

Issue 2126023002: use std::unique_ptr for the callback argument of QUIC's ProofVerifier::Verify proof to make ownersh… (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@126327823
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | net/quic/crypto/proof_test.cc » ('j') | net/quic/crypto/proof_verifier_chromium.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/quic/crypto/crypto_server_test.cc
diff --git a/net/quic/crypto/crypto_server_test.cc b/net/quic/crypto/crypto_server_test.cc
index 2e73826284a42fd2251b75a5333f2e8aad89488a..d66f3cc6ae687399eec2bf5540402be5444f5807 100644
--- a/net/quic/crypto/crypto_server_test.cc
+++ b/net/quic/crypto/crypto_server_test.cc
@@ -836,14 +836,15 @@ TEST_P(CryptoServerTest, ProofForSuppliedServerConfig) {
CryptoTestUtils::ProofVerifyContextForTesting());
std::unique_ptr<ProofVerifyDetails> details;
string error_details;
- DummyProofVerifierCallback callback;
+ std::unique_ptr<ProofVerifierCallback> callback(
+ new DummyProofVerifierCallback());
string chlo_hash;
CryptoUtils::HashHandshakeMessage(msg, &chlo_hash);
EXPECT_EQ(QUIC_SUCCESS,
proof_verifier->VerifyProof(
"test.example.com", 443, scfg_str.as_string(), client_version_,
chlo_hash, certs, "", proof.as_string(), verify_context.get(),
- &error_details, &details, &callback));
+ &error_details, &details, std::move(callback)));
}
TEST_P(CryptoServerTest, RejectInvalidXlct) {
« no previous file with comments | « no previous file | net/quic/crypto/proof_test.cc » ('j') | net/quic/crypto/proof_verifier_chromium.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698