Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(61)

Issue 2126003002: Revert of 🎣 Make Android .build_configs aware of prebuilts and java sources (Closed)

Created:
4 years, 5 months ago by agrieve
Modified:
4 years, 5 months ago
Reviewers:
Peter Wen
CC:
chromium-reviews, jbudorick+watch_chromium.org, mikecase+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Make Android .build_configs aware of prebuilts and java sources (patchset #2 id:20001 of https://codereview.chromium.org/2124663002/ ) Reason for revert: Breaks ninja noticing when .java files change. Original issue's description: > Make Android .build_configs aware of prebuilts and java sources > > This information will be necessary for generating gradle projects for > Android Studio. > > BUG=620034 > > Committed: https://crrev.com/2bb3a690dc221b8a5dac4c4d99055e69ffe712b8 > Cr-Commit-Position: refs/heads/master@{#403822} TBR=wnwen@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=620034 Committed: https://crrev.com/333d257e513ae47c7f4d09895079a6dc6822ec62 Cr-Commit-Position: refs/heads/master@{#403939}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+121 lines, -204 lines) Patch
M build/android/gyp/emma_instr.py View 4 chunks +9 lines, -16 lines 0 comments Download
M build/android/gyp/javac.py View 1 chunk +1 line, -11 lines 0 comments Download
M build/android/gyp/write_build_config.py View 6 chunks +1 line, -36 lines 0 comments Download
M build/config/android/internal_rules.gni View 15 chunks +110 lines, -141 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
agrieve
Created Revert of 🎣 Make Android .build_configs aware of prebuilts and java sources
4 years, 5 months ago (2016-07-06 19:26:33 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2126003002/1
4 years, 5 months ago (2016-07-06 19:27:22 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-06 19:28:05 UTC) #6
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-06 19:28:13 UTC) #7
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/333d257e513ae47c7f4d09895079a6dc6822ec62 Cr-Commit-Position: refs/heads/master@{#403939}
4 years, 5 months ago (2016-07-06 19:30:29 UTC) #9
agrieve
4 years, 5 months ago (2016-07-07 01:23:59 UTC) #10
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2127013002/ by agrieve@chromium.org.

The reason for reverting is: going to fix it.

Powered by Google App Engine
This is Rietveld 408576698