Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2125983002:
Bulk Reports - Add datetime metadata to traces. (Closed)
|
Created:
4 years, 5 months ago by shatch Modified:
4 years, 5 months ago Reviewers:
oystein (OOO til 10th of July) CC:
chromium-reviews, tracing+reviews_chromium.org, darin-cc_chromium.org, jam, wfh+watch_chromium.org Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionBulk Reports - Add datetime metadata to traces.
Since values don't take int64, choices are to grab the time and store it as a double or use UTCExplode and format the string like: "YYYY-MM-DD HH:MM:SS"
BUG=626076
Committed: https://crrev.com/790aa25d68f52ab6ecf5fff9fc81b2e0a4a2394c
Cr-Commit-Position: refs/heads/master@{#404944}
Patch Set 1 : . #
Total comments: 1
Patch Set 2 : Remove "ms". #Messages
Total messages: 31 (17 generated)
Patchset #1 (id:1) has been deleted
Description was changed from ========== Bulk Reports - Add datetime metadata to traces. BUG=626076 ========== to ========== Bulk Reports - Add datetime metadata to traces. Since values don't take int64, storing this as a double. Alternatively we can use UTCExplode and format the string like: "YYYY-MM-DD HH:MM:SS" BUG=626076 ==========
simonhatch@chromium.org changed reviewers: + oysteine@chromium.org
Description was changed from ========== Bulk Reports - Add datetime metadata to traces. Since values don't take int64, storing this as a double. Alternatively we can use UTCExplode and format the string like: "YYYY-MM-DD HH:MM:SS" BUG=626076 ========== to ========== Bulk Reports - Add datetime metadata to traces. Since values don't take int64, choices are to grab the time and store it as a double or use UTCExplode and format the string like: "YYYY-MM-DD HH:MM:SS" BUG=626076 ==========
Patchset #1 (id:20001) has been deleted
lgtm https://codereview.chromium.org/2125983002/diff/40001/content/browser/tracing... File content/browser/tracing/tracing_controller_impl.cc (right): https://codereview.chromium.org/2125983002/diff/40001/content/browser/tracing... content/browser/tracing/tracing_controller_impl.cc:176: metadata_dict->SetString("trace-capture-datetime-ms", time_string); Why -ms?
On 2016/07/11 18:35:21, Oystein (OOO to July11) wrote: > lgtm > > https://codereview.chromium.org/2125983002/diff/40001/content/browser/tracing... > File content/browser/tracing/tracing_controller_impl.cc (right): > > https://codereview.chromium.org/2125983002/diff/40001/content/browser/tracing... > content/browser/tracing/tracing_controller_impl.cc:176: > metadata_dict->SetString("trace-capture-datetime-ms", time_string); > Why -ms? Oops, originally wrote it thinking I could store the int64 and never changed the name after.
The CQ bit was checked by simonhatch@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from oysteine@chromium.org Link to the patchset: https://codereview.chromium.org/2125983002/#ps60001 (title: "Remove "ms".")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by simonhatch@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by simonhatch@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by simonhatch@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by simonhatch@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== Bulk Reports - Add datetime metadata to traces. Since values don't take int64, choices are to grab the time and store it as a double or use UTCExplode and format the string like: "YYYY-MM-DD HH:MM:SS" BUG=626076 ========== to ========== Bulk Reports - Add datetime metadata to traces. Since values don't take int64, choices are to grab the time and store it as a double or use UTCExplode and format the string like: "YYYY-MM-DD HH:MM:SS" BUG=626076 ==========
Message was sent while issue was closed.
Committed patchset #2 (id:60001)
Message was sent while issue was closed.
CQ bit was unchecked.
Message was sent while issue was closed.
Description was changed from ========== Bulk Reports - Add datetime metadata to traces. Since values don't take int64, choices are to grab the time and store it as a double or use UTCExplode and format the string like: "YYYY-MM-DD HH:MM:SS" BUG=626076 ========== to ========== Bulk Reports - Add datetime metadata to traces. Since values don't take int64, choices are to grab the time and store it as a double or use UTCExplode and format the string like: "YYYY-MM-DD HH:MM:SS" BUG=626076 Committed: https://crrev.com/790aa25d68f52ab6ecf5fff9fc81b2e0a4a2394c Cr-Commit-Position: refs/heads/master@{#404944} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/790aa25d68f52ab6ecf5fff9fc81b2e0a4a2394c Cr-Commit-Position: refs/heads/master@{#404944} |
