Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(279)

Issue 2125933004: Inline Declaration::IsInlineable into crankshaft (Closed)

Created:
4 years, 5 months ago by Toon Verwaest
Modified:
4 years, 5 months ago
Reviewers:
Michael Starzinger
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Inline Declaration::IsInlineable into crankshaft Those virtual methods shouldn't live on the AST since they are crankshaft specific, and can easily be checked inline. BUG= Committed: https://crrev.com/b3f827c8e4dbd845b9b07053e9cbcae46fe80b50 Cr-Commit-Position: refs/heads/master@{#37572}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -15 lines) Patch
M src/ast/ast.h View 2 chunks +0 lines, -2 lines 0 comments Download
M src/ast/ast.cc View 1 chunk +0 lines, -12 lines 0 comments Download
M src/crankshaft/hydrogen.cc View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
Toon Verwaest
ptal
4 years, 5 months ago (2016-07-07 07:53:21 UTC) #2
Michael Starzinger
LGTM. You'll still need Crankshaft owners stamp.
4 years, 5 months ago (2016-07-07 07:58:56 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2125933004/1
4 years, 5 months ago (2016-07-07 08:00:09 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-07 08:28:34 UTC) #6
commit-bot: I haz the power
4 years, 5 months ago (2016-07-07 08:29:13 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b3f827c8e4dbd845b9b07053e9cbcae46fe80b50
Cr-Commit-Position: refs/heads/master@{#37572}

Powered by Google App Engine
This is Rietveld 408576698