Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(67)

Issue 2125933003: check for zero scale in SkDraw::ComputeResScaleForStroking (Closed)

Created:
4 years, 5 months ago by lsalzman1
Modified:
4 years, 5 months ago
Reviewers:
caryclark
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

check for zero scale in SkDraw::ComputeResScaleForStroking If the transform used to compute the res scale has both 0 scale and skew, then it will currently compute a 0 res scale. This causes getFillPath to trigger an assertion while using SkStroke since that can't handle a 0 res scale. Downstream Firefox bug report: https://bugzilla.mozilla.org/show_bug.cgi?id=1284356 BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2125933003 Committed: https://skia.googlesource.com/skia/+/a4b8704e76cb2136a3ff8c1553690f30b96870e0

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
M src/core/SkDraw.cpp View 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 8 (4 generated)
lsalzman1
4 years, 5 months ago (2016-07-06 18:17:46 UTC) #3
caryclark
lgtm
4 years, 5 months ago (2016-07-06 18:53:03 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2125933003/1
4 years, 5 months ago (2016-07-06 18:54:02 UTC) #6
commit-bot: I haz the power
4 years, 5 months ago (2016-07-06 19:19:59 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/a4b8704e76cb2136a3ff8c1553690f30b96870e0

Powered by Google App Engine
This is Rietveld 408576698