Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Issue 2125933002: PPC: [fullcode][mips][mips64][ppc][s390] Avoid trashing of a home object when doing a keyed store t… (Closed)

Created:
4 years, 5 months ago by JaideepBajwa
Modified:
4 years, 5 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

PPC: [fullcode][mips][mips64][ppc][s390] Avoid trashing of a home object when doing a keyed store to a super. Port 43aee0331d2ff6ce2f6089e879665b648f2fdd15 Fixed minor typo in ppc file. R=ishell@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com, mbrandy@us.ibm.com BUG=chromium:625590 LOG=N Committed: https://crrev.com/5b823bfc6e40bc33b0037d8f478aae06167fb21f Cr-Commit-Position: refs/heads/master@{#37562}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M src/full-codegen/ppc/full-codegen-ppc.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
JaideepBajwa
PTAL
4 years, 5 months ago (2016-07-06 17:31:22 UTC) #1
john.yan
lgtm
4 years, 5 months ago (2016-07-06 17:31:31 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2125933002/1
4 years, 5 months ago (2016-07-06 17:32:08 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-06 17:57:15 UTC) #5
commit-bot: I haz the power
4 years, 5 months ago (2016-07-06 17:58:34 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5b823bfc6e40bc33b0037d8f478aae06167fb21f
Cr-Commit-Position: refs/heads/master@{#37562}

Powered by Google App Engine
This is Rietveld 408576698