Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(78)

Unified Diff: content/browser/service_worker/embedded_worker_registry.cc

Issue 212593010: Implement the ServiceWorker "activate" event during activation (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Ready, set... Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/service_worker/embedded_worker_registry.cc
diff --git a/content/browser/service_worker/embedded_worker_registry.cc b/content/browser/service_worker/embedded_worker_registry.cc
index 308108e60515ef00dfb1ca3be171b22a3e3c1049..f07e943a438fdab7775a8b867fd61388c66ed9ea 100644
--- a/content/browser/service_worker/embedded_worker_registry.cc
+++ b/content/browser/service_worker/embedded_worker_registry.cc
@@ -78,7 +78,8 @@ void EmbeddedWorkerRegistry::OnSendMessageToBrowser(
}
// Perform security check to filter out any unexpected (and non-test)
// messages. This must list up all message types that can go through here.
- if (message.type() == ServiceWorkerHostMsg_InstallEventFinished::ID ||
+ if (message.type() == ServiceWorkerHostMsg_ActivateEventFinished::ID ||
jschuh 2014/03/28 21:27:29 Why are we filtering here? Shouldn't found->second
dominicc (has gone to gerrit) 2014/03/31 03:59:33 This class acts as a proxy routing messages to a w
jschuh 2014/03/31 13:36:15 Okay, I guess @tsepez and I disagree on the value
+ message.type() == ServiceWorkerHostMsg_InstallEventFinished::ID ||
message.type() == ServiceWorkerHostMsg_FetchEventFinished::ID ||
IPC_MESSAGE_CLASS(message) == TestMsgStart) {
found->second->OnMessageReceived(request_id, message);

Powered by Google App Engine
This is Rietveld 408576698