Issue 212593009: FlameChart: move CPUProfiler related part of the FlameChart into a separate file.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 212593009: FlameChart: move CPUProfiler related part of the FlameChart into a separate file. (Closed)

Created:
6 years, 9 months ago by loislo

Modified:
6 years, 9 months ago

Reviewers:
yurys, pfeldman

CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, alph+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, aandrey+blink_chromium.org

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

FlameChart: move CPUProfiler related part of the FlameChart into a separate file. FlameChart was renamed to CPUProfileFlameChart FlameChart.MainPane was renamed to FlameChart. BUG= R=pfeldman@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=170173

Patch Set 1 #

Patch Set 2 : missed file was added. test was fixed. #

Created: 6 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+415 lines, -381 lines)			Patch
M	LayoutTests/inspector/profiler/cpu-profiler-flame-chart-overview.html	View	1	1 chunk	+6 lines, -6 lines	0 comments	Download
M	Source/devtools/devtools.gypi	View		1 chunk	+1 line, -0 lines	0 comments	Download
A	Source/devtools/front_end/CPUProfileFlameChart.js	View	1	1 chunk	+362 lines, -0 lines	0 comments	Download
M	Source/devtools/front_end/CPUProfileView.js	View		2 chunks	+3 lines, -3 lines	0 comments	Download
M	Source/devtools/front_end/FlameChart.js	View		4 chunks	+38 lines, -371 lines	0 comments	Download
M	Source/devtools/front_end/ProfilesPanel.js	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	Source/devtools/front_end/TimelineFlameChart.js	View		1 chunk	+1 line, -1 line	0 comments	Download
M	Source/devtools/front_end/profilesPanel.css	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	Source/devtools/scripts/frontend_modules.json	View		1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

loislo

6 years, 9 months ago (2014-03-27 12:48:35 UTC) #3

Message was sent while issue was closed.

Committed patchset #2 manually as r170173 (presubmit successful).

Expand Messages | Collapse Messages