Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(100)

Issue 212593007: MSE: Update WebM buffered range expectations w.r.t. frame duration processing (Closed)

Created:
6 years, 9 months ago by wolenetz
Modified:
6 years, 9 months ago
CC:
blink-reviews
Visibility:
Public.

Description

MSE: Update WebM buffered range expectations w.r.t. frame duration processing Chromium-side changes to parse and use optional WebM TrackEntry DefaultDuration, derive simpleblock frame durations from subsequent frame duration, or estimate missing frame duration as the maximum duration seen so far cause changes in mediasource buffered range tests. This change updates the tests relative to the new WebM frame duration parsing/derivation/defaulting. Also includes TestExpectations update to allow these tests to fail until Chromium side lands. BUG=351166 TBR=acolwell@chromium.org TEST=All media layout tests pass locally on Linux (with the Chromium prereq CLs applied), and failure is allowed by TestExpectations (without the prereq CLs applied) Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=170209

Patch Set 1 #

Patch Set 2 : Include failure expectation for these tests so this can land before Chromium side #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -4 lines) Patch
M LayoutTests/TestExpectations View 1 1 chunk +5 lines, -0 lines 0 comments Download
M LayoutTests/http/tests/media/media-source/mediasource-buffered.html View 2 chunks +2 lines, -2 lines 0 comments Download
M LayoutTests/http/tests/media/media-source/webkitmediasource-append-in-ended-state.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/http/tests/media/media-source/webkitmediasource-zero-byte-append-in-ended-state.html View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 14 (0 generated)
wolenetz
PTAL. This is CL #3, and depends on behavior on Chromium side landing first in: ...
6 years, 9 months ago (2014-03-26 22:18:20 UTC) #1
acolwell GONE FROM CHROMIUM
lgtm
6 years, 9 months ago (2014-03-27 18:40:13 UTC) #2
wolenetz
I've changed this to TBR per offline discussion of inclusion of TestExpectations change in this ...
6 years, 9 months ago (2014-03-27 18:52:45 UTC) #3
wolenetz
The CQ bit was checked by wolenetz@chromium.org
6 years, 9 months ago (2014-03-27 18:53:19 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/wolenetz@chromium.org/212593007/20001
6 years, 9 months ago (2014-03-27 18:53:24 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-27 21:13:36 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on win_blink_rel
6 years, 9 months ago (2014-03-27 21:13:36 UTC) #7
wolenetz
The CQ bit was checked by wolenetz@chromium.org
6 years, 9 months ago (2014-03-27 21:24:34 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/wolenetz@chromium.org/212593007/20001
6 years, 9 months ago (2014-03-27 21:24:37 UTC) #9
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-27 22:32:44 UTC) #10
commit-bot: I haz the power
Commit queue rejected this change because the description was changed between the time the change ...
6 years, 9 months ago (2014-03-27 22:32:45 UTC) #11
wolenetz
The CQ bit was checked by wolenetz@chromium.org
6 years, 9 months ago (2014-03-27 22:33:34 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/wolenetz@chromium.org/212593007/20001
6 years, 9 months ago (2014-03-27 22:34:24 UTC) #13
commit-bot: I haz the power
6 years, 9 months ago (2014-03-27 22:36:21 UTC) #14
Message was sent while issue was closed.
Change committed as 170209

Powered by Google App Engine
This is Rietveld 408576698