Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(351)

Issue 2125913004: PPC/s390: [builtins] Fix MathMaxMin on arm and arm64 (Closed)

Created:
4 years, 5 months ago by JaideepBajwa
Modified:
4 years, 5 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

PPC/s390: [builtins] Fix MathMaxMin on arm and arm64 Port b86ac0e05a1e4a34944bdc3c0c6702945387b431 Original commit message: Both of these were broken in different ways: * On arm, the loop counter was passed as argc on the stack. * On arm64, we passed argc + 1 instead of argc. The result in both cases was an incorrect receiver for the builtin frame when generating stack traces. R=jgruber@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com, mbrandy@us.ibm.com BUG=v8:4815 LOG=N Committed: https://crrev.com/32e843dfc6b36b3f03a3930028de62cc15da0295 Cr-Commit-Position: refs/heads/master@{#37567}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -19 lines) Patch
M src/ppc/builtins-ppc.cc View 3 chunks +13 lines, -10 lines 0 comments Download
M src/s390/builtins-s390.cc View 3 chunks +12 lines, -9 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
JaideepBajwa
PTAL
4 years, 5 months ago (2016-07-07 00:44:32 UTC) #1
john.yan
lgtm
4 years, 5 months ago (2016-07-07 00:54:38 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2125913004/1
4 years, 5 months ago (2016-07-07 01:03:10 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-07 01:27:40 UTC) #5
commit-bot: I haz the power
4 years, 5 months ago (2016-07-07 01:29:13 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/32e843dfc6b36b3f03a3930028de62cc15da0295
Cr-Commit-Position: refs/heads/master@{#37567}

Powered by Google App Engine
This is Rietveld 408576698