Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(339)

Issue 2125893003: HTMLDialogElement#showModal() should ignore unfocusable elements with [autofocus] (Closed)

Created:
4 years, 5 months ago by Dan Beam
Modified:
4 years, 5 months ago
Reviewers:
tkent, falken
CC:
blink-reviews, blink-reviews-html_chromium.org, chromium-reviews, dglazkov+blink
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

HTMLDialogElement#showModal() should ignore unfocusable elements with [autofocus] """ Let control be the first non-inert *focusable* area in subject's control group whose DOM anchor has an autofocus attribute specified. """ https://html.spec.whatwg.org/multipage/forms.html#dialog-focusing-steps R=falken@chromium.org BUG=626041 Committed: https://crrev.com/4e83c20aacf7d5b4deddf638da54239fe9a7bfdb Cr-Commit-Position: refs/heads/master@{#404177}

Patch Set 1 #

Patch Set 2 : update dialog-autofocus-multiple-times.html #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -1 line) Patch
M third_party/WebKit/LayoutTests/fast/dom/HTMLDialogElement/dialog-autofocus.html View 1 chunk +3 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/dom/HTMLDialogElement/dialog-autofocus-multiple-times.html View 1 1 chunk +3 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLDialogElement.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 19 (9 generated)
Dan Beam
i verified the test fails without my patch
4 years, 5 months ago (2016-07-06 16:59:37 UTC) #1
Dan Beam
+falken@ I guess I also need to find an OWNER afterward? esprehn@'s OOO
4 years, 5 months ago (2016-07-06 23:11:44 UTC) #7
falken
Thanks for the fix! Could you do also revise fast/dom/HTMLDialogElement/dialog-autofocus-multiple-times.html in a similar way? That ...
4 years, 5 months ago (2016-07-07 00:18:58 UTC) #9
Dan Beam
On 2016/07/07 00:18:58, falken wrote: > Thanks for the fix! Could you do also revise ...
4 years, 5 months ago (2016-07-07 00:39:51 UTC) #10
falken
lgtm
4 years, 5 months ago (2016-07-07 00:41:51 UTC) #11
tkent
lgtm
4 years, 5 months ago (2016-07-07 00:56:45 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2125893003/20001
4 years, 5 months ago (2016-07-07 17:04:41 UTC) #14
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 5 months ago (2016-07-07 17:59:53 UTC) #16
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-07 18:00:00 UTC) #17
commit-bot: I haz the power
4 years, 5 months ago (2016-07-07 18:02:32 UTC) #19
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/4e83c20aacf7d5b4deddf638da54239fe9a7bfdb
Cr-Commit-Position: refs/heads/master@{#404177}

Powered by Google App Engine
This is Rietveld 408576698