HTMLDialogElement#showModal() should ignore unfocusable elements with [autofocus]

HTMLDialogElement#showModal() should ignore unfocusable elements with [autofocus]

"""
Let control be the first non-inert *focusable* area in subject's
control group whose DOM anchor has an autofocus attribute specified.
"""

https://html.spec.whatwg.org/multipage/forms.html#dialog-focusing-steps

R=falken@chromium.org
BUG=626041
Committed: https://crrev.com/4e83c20aacf7d5b4deddf638da54239fe9a7bfdb
Cr-Commit-Position: refs/heads/master@{#404177}

[Dan Beam, 2016-07-06 16:59:37]

i verified the test fails without my patch

[Dan Beam, 2016-07-06 17:00:33]

Description was changed from

==========
HTMLDialogElement#showModal() should ignore unfocusable elements with
[autofocus]

R=esprehn@chromium.org
BUG=625332
==========

to

==========
HTMLDialogElement#showModal() should ignore unfocusable elements with
[autofocus]

"""
Let control be the first non-inert *focusable* area in subject's control group
whose DOM anchor has an autofocus attribute specified.
"""

https://html.spec.whatwg.org/multipage/forms.html#dialog-focusing-steps

R=esprehn@chromium.org
BUG=625332
==========

[Dan Beam, 2016-07-06 17:00:45]

Description was changed from

==========
HTMLDialogElement#showModal() should ignore unfocusable elements with
[autofocus]

"""
Let control be the first non-inert *focusable* area in subject's control group
whose DOM anchor has an autofocus attribute specified.
"""

https://html.spec.whatwg.org/multipage/forms.html#dialog-focusing-steps

R=esprehn@chromium.org
BUG=625332
==========

to

==========
HTMLDialogElement#showModal() should ignore unfocusable elements with
[autofocus]

"""
Let control be the first non-inert *focusable* area in subject's
control group whose DOM anchor has an autofocus attribute specified.
"""

https://html.spec.whatwg.org/multipage/forms.html#dialog-focusing-steps

R=esprehn@chromium.org
BUG=625332
==========

[Dan Beam, 2016-07-06 17:03:51]

Description was changed from

==========
HTMLDialogElement#showModal() should ignore unfocusable elements with
[autofocus]

"""
Let control be the first non-inert *focusable* area in subject's
control group whose DOM anchor has an autofocus attribute specified.
"""

https://html.spec.whatwg.org/multipage/forms.html#dialog-focusing-steps

R=esprehn@chromium.org
BUG=625332
==========

to

==========
HTMLDialogElement#showModal() should ignore unfocusable elements with
[autofocus]

"""
Let control be the first non-inert *focusable* area in subject's
control group whose DOM anchor has an autofocus attribute specified.
"""

https://html.spec.whatwg.org/multipage/forms.html#dialog-focusing-steps

R=esprehn@chromium.org
BUG=626041
==========

[Dan Beam, 2016-07-06 23:10:56]

Description was changed from

==========
HTMLDialogElement#showModal() should ignore unfocusable elements with
[autofocus]

"""
Let control be the first non-inert *focusable* area in subject's
control group whose DOM anchor has an autofocus attribute specified.
"""

https://html.spec.whatwg.org/multipage/forms.html#dialog-focusing-steps

R=esprehn@chromium.org
BUG=626041
==========

to

==========
HTMLDialogElement#showModal() should ignore unfocusable elements with
[autofocus]

"""
Let control be the first non-inert *focusable* area in subject's
control group whose DOM anchor has an autofocus attribute specified.
"""

https://html.spec.whatwg.org/multipage/forms.html#dialog-focusing-steps

R=falken@chromium.org
BUG=626041
==========

[Dan Beam, 2016-07-06 23:10:56]

dbeam@chromium.org changed reviewers:
+ falken@chromium.org
- esprehn@chromium.org

[Dan Beam, 2016-07-06 23:11:44]

+falken@

I guess I also need to find an OWNER afterward?  esprehn@'s OOO

[falken, 2016-07-07 00:18:58]

falken@chromium.org changed reviewers:
+ tkent@chromium.org

[falken, 2016-07-07 00:18:58]

Thanks for the fix! Could you do also revise
fast/dom/HTMLDialogElement/dialog-autofocus-multiple-times.html in a similar
way? That test exercises show() not just showModal().

Yes you'll need an OWNER. I think +tkent@ would be good and he understands
focusing and controls very well.

[Dan Beam, 2016-07-07 00:39:51]

On 2016/07/07 00:18:58, falken wrote:
> Thanks for the fix! Could you do also revise
> fast/dom/HTMLDialogElement/dialog-autofocus-multiple-times.html in a similar
> way? That test exercises show() not just showModal().

Done.

[falken, 2016-07-07 00:41:51]

lgtm

[tkent, 2016-07-07 00:56:45]

lgtm

[Dan Beam, 2016-07-07 17:03:39]

The CQ bit was checked by dbeam@chromium.org

[commit-bot: I haz the power, 2016-07-07 17:04:41]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-07 17:59:52]

Description was changed from

==========
HTMLDialogElement#showModal() should ignore unfocusable elements with
[autofocus]

"""
Let control be the first non-inert *focusable* area in subject's
control group whose DOM anchor has an autofocus attribute specified.
"""

https://html.spec.whatwg.org/multipage/forms.html#dialog-focusing-steps

R=falken@chromium.org
BUG=626041
==========

to

==========
HTMLDialogElement#showModal() should ignore unfocusable elements with
[autofocus]

"""
Let control be the first non-inert *focusable* area in subject's
control group whose DOM anchor has an autofocus attribute specified.
"""

https://html.spec.whatwg.org/multipage/forms.html#dialog-focusing-steps

R=falken@chromium.org
BUG=626041
==========

[commit-bot: I haz the power, 2016-07-07 17:59:53]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-07-07 18:00:00]

CQ bit was unchecked.

[commit-bot: I haz the power, 2016-07-07 18:02:30]

Description was changed from

==========
HTMLDialogElement#showModal() should ignore unfocusable elements with
[autofocus]

"""
Let control be the first non-inert *focusable* area in subject's
control group whose DOM anchor has an autofocus attribute specified.
"""

https://html.spec.whatwg.org/multipage/forms.html#dialog-focusing-steps

R=falken@chromium.org
BUG=626041
==========

to

==========
HTMLDialogElement#showModal() should ignore unfocusable elements with
[autofocus]

"""
Let control be the first non-inert *focusable* area in subject's
control group whose DOM anchor has an autofocus attribute specified.
"""

https://html.spec.whatwg.org/multipage/forms.html#dialog-focusing-steps

R=falken@chromium.org
BUG=626041

Committed: https://crrev.com/4e83c20aacf7d5b4deddf638da54239fe9a7bfdb
Cr-Commit-Position: refs/heads/master@{#404177}
==========

[commit-bot: I haz the power, 2016-07-07 18:02:32]

Patchset 2 (id:??) landed as
https://crrev.com/4e83c20aacf7d5b4deddf638da54239fe9a7bfdb
Cr-Commit-Position: refs/heads/master@{#404177}