Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(218)

Issue 2125883004: [MD Settings] Only mention the App Launcher on ChromeOS for the "Use a prediction service.." setting (Closed)

Created:
4 years, 5 months ago by tapted
Modified:
4 years, 5 months ago
Reviewers:
tommycli
CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[MD Settings] Only mention the App Launcher on ChromeOS for the "Use a prediction service.." setting Fixed for regular settings (generated_resources.grd) in r394368. Apply the same fix for MD settings (settings_strings.grdp). It currently says, "Use a prediction service to help complete searches and URLs typed in the address bar or the app launcher search box" App Launcher only exists on ChromeOS now, so drop the "or the app launcher.." bit on other platforms. BUG=612651 Committed: https://crrev.com/cc8cdf3f9e3153a81a2870b72b6b2ca10f8309f6 Cr-Commit-Position: refs/heads/master@{#404271}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -3 lines) Patch
M chrome/app/settings_strings.grdp View 1 chunk +10 lines, -3 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
tapted
Hi Tommy, please take a look
4 years, 5 months ago (2016-07-07 02:50:41 UTC) #3
tommycli
lgtm thanks
4 years, 5 months ago (2016-07-07 16:38:01 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2125883004/1
4 years, 5 months ago (2016-07-07 23:54:22 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-08 00:00:36 UTC) #8
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-08 00:00:38 UTC) #9
commit-bot: I haz the power
4 years, 5 months ago (2016-07-08 00:02:06 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/cc8cdf3f9e3153a81a2870b72b6b2ca10f8309f6
Cr-Commit-Position: refs/heads/master@{#404271}

Powered by Google App Engine
This is Rietveld 408576698