services/ui/public/cpp/window_manager_delegate.h - Issue 2125883003: Adds ability for pre-target accelerators to not consume events

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: services/ui/public/cpp/window_manager_delegate.h

Issue 2125883003: Adds ability for pre-target accelerators to not consume events (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: comments Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « services/ui/public/cpp/tests/window_server_test_base.cc ('k') | services/ui/public/cpp/window_manager_delegate.cc » ('j') | services/ui/ws/event_dispatcher.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: services/ui/public/cpp/window_manager_delegate.h

diff --git a/services/ui/public/cpp/window_manager_delegate.h b/services/ui/public/cpp/window_manager_delegate.h

index f9d3a15ca1abd0cf1d31ac9249e996406ba626b2..fe3b72bc9ac904f41dea75c05c1d6f33ce168ab2 100644

--- a/services/ui/public/cpp/window_manager_delegate.h

+++ b/services/ui/public/cpp/window_manager_delegate.h

@@ -106,7 +106,7 @@ class WindowManagerDelegate {

virtual void OnWmNewDisplay(Window* window,

const display::Display& display) = 0;

- virtual void OnAccelerator(uint32_t id, const ui::Event& event) = 0;

+ virtual mojom::EventResult OnAccelerator(uint32_t id, const ui::Event& event);

sadrul 2016/07/08 15:40:43 ui::EventResult instead?

sky 2016/07/08 16:23:51 This code only cares about two results. ui::EventR

virtual void OnWmPerformMoveLoop(

Window* window,