Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(367)

Unified Diff: services/ui/public/interfaces/window_manager.mojom

Issue 2125883003: Adds ability for pre-target accelerators to not consume events (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: merge Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « services/ui/public/interfaces/event_matcher.mojom ('k') | services/ui/public/interfaces/window_tree.mojom » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: services/ui/public/interfaces/window_manager.mojom
diff --git a/services/ui/public/interfaces/window_manager.mojom b/services/ui/public/interfaces/window_manager.mojom
index 66dd5069b9a2ebe9aa83e0d57048b8104aff2d76..85e0dd554086ff5a449fe31dd1325a6e6f7b34ef 100644
--- a/services/ui/public/interfaces/window_manager.mojom
+++ b/services/ui/public/interfaces/window_manager.mojom
@@ -93,8 +93,10 @@ interface WindowManager {
// Asks the WindowManager to cancel any outstanding move loop on |change_id|.
WmCancelMoveLoop(uint32 change_id);
- // An accelerator registered via AddAccelerator() has been triggered.
- OnAccelerator(uint32 id, ui.mojom.Event event);
+ // An accelerator registered via AddAccelerator() has been triggered. If
+ // |ack_id| is non-zero the accelerator matches a PRE_TARGET and must be
+ // acknowledged by WindowManagerClient::OnAcceleratorAck().
+ OnAccelerator(uint32 ack_id, uint32 accelerator_id, ui.mojom.Event event);
};
// This interface is only used as an associated interface and is associated
@@ -121,6 +123,8 @@ interface WindowManagerClient {
// easily identify the accelerator's action. If an accelerator with the same
// id or the same matcher already exists, then the accelerator is not added.
// Accelerator ids 1 << 31 and above are reserved for internal use.
+ //
+ // See WindowTree for details on event dispatch.
AddAccelerator(uint32 id, EventMatcher matcher) => (bool success);
RemoveAccelerator(uint32 id);
@@ -141,4 +145,8 @@ interface WindowManagerClient {
// Response from WmCreateTopLevelWindow() informing the client of the id for
// the new window.
OnWmCreatedTopLevelWindow(uint32 change_id, uint32 window_id);
+
+ // See description in WindowManager::OnAccelerator(). |ack_id| is the value
+ // that was passed to OnAccelerator().
+ OnAcceleratorAck(uint32 ack_id, EventResult event_result);
};
« no previous file with comments | « services/ui/public/interfaces/event_matcher.mojom ('k') | services/ui/public/interfaces/window_tree.mojom » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698