Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1743)

Unified Diff: ui/events/mojo/event_constants.mojom

Issue 2125883003: Adds ability for pre-target accelerators to not consume events (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« services/ui/ws/window_tree.cc ('K') | « ui/events/mojo/OWNERS ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/events/mojo/event_constants.mojom
diff --git a/ui/events/mojo/event_constants.mojom b/ui/events/mojo/event_constants.mojom
index 445cffbade6c7bc45755ede8f25e6898ad210201..b2c09332a14540edc074807ce7b80dfaae291d39 100644
--- a/ui/events/mojo/event_constants.mojom
+++ b/ui/events/mojo/event_constants.mojom
@@ -4,10 +4,13 @@
module ui.mojom;
-// Denotes during which phase of event targeting that an accelerator will be
-// notified of an event. PRE_TARGET will be notified instead of the target
-// window. POST_TARGET will be notified after the target window, and only if the
-// event was not consumed by the target.
+// AcceleratorPhase specifies which phase of event matching the matcher should
+// be considered for. Event processing happens in the following order:
+// . EventMatcher registered for PRE_TARGET. If the EventMatcher does not
dcheng 2016/07/07 04:04:21 I was wondering this while reviewing the dragging
sky 2016/07/07 13:38:38 I've moved these comments to clarify they are for
+// consume the event, then the following are considered.
+// . Target window (lookup of the target window depends upon the event type).
+// . EventMatcher registered for POST_TARGET. These matchers are only considered
+// if the target window does not consume the event.
enum AcceleratorPhase {
PRE_TARGET,
POST_TARGET,
« services/ui/ws/window_tree.cc ('K') | « ui/events/mojo/OWNERS ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698