Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(44)

Issue 2125883002: Roll src/third_party/skia/ 1e2a702c1..4be9a30ae (5 commits). (Closed)

Created:
4 years, 5 months ago by skia-deps-roller
Modified:
4 years, 5 months ago
Reviewers:
rmistry
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Roll src/third_party/skia/ 1e2a702c1..4be9a30ae (5 commits). https://chromium.googlesource.com/skia.git/+log/1e2a702c1959..4be9a30aed39 $ git log 1e2a702c1..4be9a30ae --date=short --no-merges --format='%ad %ae %s' 2016-07-06 bsalomon Increase batching for AA fill rects. 2016-07-06 ethannicholas fix for Clang 3.8 warning in SkSL GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2118033002 2016-07-06 benjaminwagner Blacklist fontscalerdistortable on Win8. 2016-07-06 bsalomon Enlarge strokerect GM size to reveal hidden content GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2126723002 2016-07-06 fmalita Document SkSurface::MakeRaster's memory initialization CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel TBR=rmistry@google.com Committed: https://crrev.com/c862d885af12c6d922fda7a1d082cbe7e8500fdc Cr-Commit-Position: refs/heads/master@{#403911}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (2 generated)
skia-deps-roller
4 years, 5 months ago (2016-07-06 14:28:16 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2125883002/1
4 years, 5 months ago (2016-07-06 14:28:28 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-06 15:35:39 UTC) #4
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/c862d885af12c6d922fda7a1d082cbe7e8500fdc Cr-Commit-Position: refs/heads/master@{#403911}
4 years, 5 months ago (2016-07-06 15:37:30 UTC) #6
sgurun-gerrit only
A revert of this CL (patchset #1 id:1) has been created in https://codereview.chromium.org/2122293002/ by sgurun@chromium.org. ...
4 years, 5 months ago (2016-07-06 17:41:31 UTC) #7
brucedawson
On 2016/07/06 17:41:31, sgurun wrote: > A revert of this CL (patchset #1 id:1) has ...
4 years, 5 months ago (2016-07-06 18:28:41 UTC) #8
rmistry
On 2016/07/06 18:28:41, brucedawson wrote: > On 2016/07/06 17:41:31, sgurun wrote: > > A revert ...
4 years, 5 months ago (2016-07-06 18:38:52 UTC) #9
rmistry
4 years, 5 months ago (2016-07-06 18:53:24 UTC) #10
Message was sent while issue was closed.
On 2016/07/06 18:38:52, rmistry wrote:
> On 2016/07/06 18:28:41, brucedawson wrote:
> > On 2016/07/06 17:41:31, sgurun wrote:
> > > A revert of this CL (patchset #1 id:1) has been created in
> > > https://codereview.chromium.org/2122293002/ by mailto:sgurun@chromium.org.
> > > 
> > > The reason for reverting is: Reverting speculatively since the
> android_webview
> > > test apk and chrome_public_test_apk started failing. 
> > > 
> > > I will revert the revert if this is not the reason..
> > 
> > The timeline doesn't seem to line up. This CL showed up in build 28630:
> > 
> >
>
https://build.chromium.org/p/chromium.linux/builders/Android%20Tests/builds/2...
> > 
> > but the failures were seen in build 28629. But, we'll see what happens.
> 
> Yes timeline does not line up and due to that the build with the revert still
> failed.
> Please revert the revert.

Nevermind, a new Skia deps roll is about to land.

Powered by Google App Engine
This is Rietveld 408576698