Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(343)

Issue 2125833004: Revert of cc::CompositorFrame: Implement ParamTraits vs. StructTraits perf test (Closed)

Created:
4 years, 5 months ago by brucedawson
Modified:
4 years, 5 months ago
CC:
chromium-reviews, cc-bugs_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of cc::CompositorFrame: Implement ParamTraits vs. StructTraits perf test (patchset #6 id:100001 of https://codereview.chromium.org/2109863002/ ) Reason for revert: Compile error on Mac GYP (dbg) builds: ../../cc/ipc/cc_serialization_perftest.cc:10:10: fatal error: 'cc/ipc/compositor_frame.mojom.h' file not found #include "cc/ipc/compositor_frame.mojom.h" http://build.chromium.org/p/chromium.mac/builders/Mac%20GYP%20%28dbg%29/builds/583/steps/compile/logs/stdio Original issue's description: > cc::CompositorFrame: Implement ParamTraits vs. StructTraits perf test > > This CL modifies the existing cc ParamTraits perf test to > also perform the equivalent test using Mojo StructTraits, > and compares the two side by side. > > This CL creates CompositorFrames with SolidColorDrawQuads > instead of PictureDrawQuads because PictureDrawQuads are > not serialized by other ParamTraits or StructTraits. > > Finally, this CL renames CCParamTraitsPerfTest to > CCSerializationPerfTest to better capture what it does. > > BUG=624459 > CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel > > Committed: https://crrev.com/0409a7c70ee6087295121da095b5520c2fe14499 > Cr-Commit-Position: refs/heads/master@{#404011} TBR=yzshen@chromium.org,danakj@chromium.org,dcheng@chromium.org,fsamuel@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=624459 Committed: https://crrev.com/ffec10a1d1f56eefae0ea850cc382ecbba653979 Cr-Commit-Position: refs/heads/master@{#404029}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+157 lines, -222 lines) Patch
M cc/BUILD.gn View 2 chunks +1 line, -4 lines 0 comments Download
M cc/cc_tests.gyp View 1 chunk +1 line, -1 line 0 comments Download
A cc/ipc/cc_param_traits_perftest.cc View 1 chunk +155 lines, -0 lines 0 comments Download
D cc/ipc/cc_serialization_perftest.cc View 1 chunk +0 lines, -217 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
brucedawson
Created Revert of cc::CompositorFrame: Implement ParamTraits vs. StructTraits perf test
4 years, 5 months ago (2016-07-07 01:04:59 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2125833004/1
4 years, 5 months ago (2016-07-07 01:05:40 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-07 01:06:34 UTC) #5
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-07 01:06:43 UTC) #6
commit-bot: I haz the power
4 years, 5 months ago (2016-07-07 01:09:08 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ffec10a1d1f56eefae0ea850cc382ecbba653979
Cr-Commit-Position: refs/heads/master@{#404029}

Powered by Google App Engine
This is Rietveld 408576698