Add custom UIPresentationController for picker selector

Add custom UIPresentationController for picker selector

Add custom UIPresentationController subclass for presenting the picker
selector. The presentation controller sets the frame of the picker
selector to be at the bottom of the screen, and adds a dimming view
behind it.

BUG=622244
Committed: https://crrev.com/3920fa079d497a524eeca5ff3eb6ef0a8981d3e7
Cr-Commit-Position: refs/heads/master@{#403902}

[Jackie Quinn, 2016-07-06 10:44:19]

jyquinn@chromium.org changed reviewers:
+ marq@chromium.org

[marq (ping after 24h), 2016-07-06 12:42:14]

LGTM, with two nits.

https://codereview.chromium.org/2125813002/diff/20001/ios/chrome/browser/ui/e...
File ios/chrome/browser/ui/elements/selector_picker_presentation_controller.mm
(right):

https://codereview.chromium.org/2125813002/diff/20001/ios/chrome/browser/ui/e...
ios/chrome/browser/ui/elements/selector_picker_presentation_controller.mm:21:
initWithPresentedViewController:(UIViewController*)presentedViewController
nit: You can make these lines a bit less torturously long by using shorter
variable names. I don't like, and our coding style agrees with me, repeating
types in variable names. I think 'presentee' and 'presenter' are fine
(especially given that you don't reuse them outside of this method).

https://codereview.chromium.org/2125813002/diff/20001/ios/chrome/browser/ui/e...
File ios/chrome/browser/ui/elements/selector_picker_view_controller.mm (right):

https://codereview.chromium.org/2125813002/diff/20001/ios/chrome/browser/ui/e...
ios/chrome/browser/ui/elements/selector_picker_view_controller.mm:94:
target:self
This should still be nil, unless you've found a problem with that.

[Jackie Quinn, 2016-07-06 13:03:23]

Thanks for the quick review!

https://codereview.chromium.org/2125813002/diff/20001/ios/chrome/browser/ui/e...
File ios/chrome/browser/ui/elements/selector_picker_presentation_controller.mm
(right):

https://codereview.chromium.org/2125813002/diff/20001/ios/chrome/browser/ui/e...
ios/chrome/browser/ui/elements/selector_picker_presentation_controller.mm:21:
initWithPresentedViewController:(UIViewController*)presentedViewController
On 2016/07/06 12:42:14, marq wrote:
> nit: You can make these lines a bit less torturously long by using shorter
> variable names. I don't like, and our coding style agrees with me, repeating
> types in variable names. I think 'presentee' and 'presenter' are fine
> (especially given that you don't reuse them outside of this method).

cool, I like that idea. Done.

https://codereview.chromium.org/2125813002/diff/20001/ios/chrome/browser/ui/e...
File ios/chrome/browser/ui/elements/selector_picker_view_controller.mm (right):

https://codereview.chromium.org/2125813002/diff/20001/ios/chrome/browser/ui/e...
ios/chrome/browser/ui/elements/selector_picker_view_controller.mm:94:
target:self
On 2016/07/06 12:42:14, marq wrote:
> This should still be nil, unless you've found a problem with that.

When it's nil, the actions in SelectorPickerViewController don't get called. I'm
not sure why :-(

[Jackie Quinn, 2016-07-06 13:05:16]

The CQ bit was checked by jyquinn@chromium.org

[Jackie Quinn, 2016-07-06 13:05:16]

The patchset sent to the CQ was uploaded after l-g-t-m from marq@chromium.org
Link to the patchset: https://codereview.chromium.org/2125813002/#ps40001
(title: "name shortening")

[commit-bot: I haz the power, 2016-07-06 13:05:23]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-06 14:00:54]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-07-06 14:02:06]

Description was changed from

==========
Add custom UIPresentationController for picker selector

Add custom UIPresentationController subclass for presenting the picker
selector. The presentation controller sets the frame of the picker
selector to be at the bottom of the screen, and adds a dimming view
behind it.

BUG=622244
==========

to

==========
Add custom UIPresentationController for picker selector

Add custom UIPresentationController subclass for presenting the picker
selector. The presentation controller sets the frame of the picker
selector to be at the bottom of the screen, and adds a dimming view
behind it.

BUG=622244

Committed: https://crrev.com/3920fa079d497a524eeca5ff3eb6ef0a8981d3e7
Cr-Commit-Position: refs/heads/master@{#403902}
==========

[commit-bot: I haz the power, 2016-07-06 14:02:07]

Patchset 3 (id:??) landed as
https://crrev.com/3920fa079d497a524eeca5ff3eb6ef0a8981d3e7
Cr-Commit-Position: refs/heads/master@{#403902}