Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(507)

Unified Diff: src/runtime/runtime-wasm.cc

Issue 2125793002: [runtime] Deprecate RUNTIME_ASSERT from WASM methods. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/runtime/runtime-wasm.cc
diff --git a/src/runtime/runtime-wasm.cc b/src/runtime/runtime-wasm.cc
index 0e86ccc3712eaf3d3e710eb2c5fe880d2690c024..ff99e242e14610ad28dd029047568f1e358576c8 100644
--- a/src/runtime/runtime-wasm.cc
+++ b/src/runtime/runtime-wasm.cc
@@ -21,7 +21,7 @@ RUNTIME_FUNCTION(Runtime_WasmGrowMemory) {
HandleScope scope(isolate);
DCHECK_EQ(1, args.length());
uint32_t delta_pages = 0;
- RUNTIME_ASSERT(args[0]->ToUint32(&delta_pages));
+ CHECK(args[0]->ToUint32(&delta_pages));
Handle<JSObject> module_object;
{
@@ -35,7 +35,7 @@ RUNTIME_FUNCTION(Runtime_WasmGrowMemory) {
FixedArray* deopt_data = code->deoptimization_data();
DCHECK(deopt_data->length() == 2);
module_object = Handle<JSObject>::cast(handle(deopt_data->get(0), isolate));
- RUNTIME_ASSERT(!module_object->IsNull(isolate));
+ CHECK(!module_object->IsNull(isolate));
}
Address old_mem_start, new_mem_start;
@@ -103,8 +103,8 @@ RUNTIME_FUNCTION(Runtime_WasmGrowMemory) {
// Set new buffer to be wasm memory
module_object->SetInternalField(kWasmMemArrayBuffer, *buffer);
- RUNTIME_ASSERT(wasm::UpdateWasmModuleMemory(
- module_object, old_mem_start, new_mem_start, old_size, new_size));
+ CHECK(wasm::UpdateWasmModuleMemory(module_object, old_mem_start,
+ new_mem_start, old_size, new_size));
return *isolate->factory()->NewNumberFromUint(old_size /
wasm::WasmModule::kPageSize);
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698