Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(538)

Issue 2125793002: [runtime] Deprecate RUNTIME_ASSERT from WASM methods. (Closed)

Created:
4 years, 5 months ago by Michael Starzinger
Modified:
4 years, 5 months ago
Reviewers:
titzer
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[runtime] Deprecate RUNTIME_ASSERT from WASM methods. This removes explicit uses of the RUNTIME_ASSERT macro from some runtime methods. The implicit ones in CONVERT_FOO_ARG_CHECKED will be addressed in a separate CL for all runtime modules at once. R=titzer@chromium.org BUG=v8:5066 Committed: https://crrev.com/1c39586a3bb76b3795ca778d33ceebc3465c18bf Cr-Commit-Position: refs/heads/master@{#37547}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M src/runtime/runtime-wasm.cc View 3 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Michael Starzinger
4 years, 5 months ago (2016-07-06 09:19:19 UTC) #1
titzer
lgtm
4 years, 5 months ago (2016-07-06 09:33:39 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2125793002/1
4 years, 5 months ago (2016-07-06 10:03:29 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-06 10:05:31 UTC) #5
commit-bot: I haz the power
4 years, 5 months ago (2016-07-06 10:06:49 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1c39586a3bb76b3795ca778d33ceebc3465c18bf
Cr-Commit-Position: refs/heads/master@{#37547}

Powered by Google App Engine
This is Rietveld 408576698