Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(533)

Issue 2125773005: [turbofan] Context in debugger is accurate by now. (Closed)

Created:
4 years, 5 months ago by Michael Starzinger
Modified:
4 years, 5 months ago
Reviewers:
mvstanton
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Context in debugger is accurate by now. This enables tests which rely on the context available at "debugger" statements to be accurate. This is the case by now when deoptimization information is available. R=mvstanton@chromium.org BUG=v8:4035 Committed: https://crrev.com/b3b1bf279a84b9223c32ea4b61883c225d54d686 Cr-Commit-Position: refs/heads/master@{#37590}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -10 lines) Patch
M test/mjsunit/mjsunit.status View 2 chunks +1 line, -10 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
Michael Starzinger
4 years, 5 months ago (2016-07-07 13:49:21 UTC) #1
mvstanton
lgtm
4 years, 5 months ago (2016-07-07 14:22:24 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2125773005/1
4 years, 5 months ago (2016-07-07 14:23:45 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-07 14:25:25 UTC) #5
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-07 14:25:27 UTC) #6
commit-bot: I haz the power
4 years, 5 months ago (2016-07-07 14:27:02 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b3b1bf279a84b9223c32ea4b61883c225d54d686
Cr-Commit-Position: refs/heads/master@{#37590}

Powered by Google App Engine
This is Rietveld 408576698