Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(226)

Issue 212573005: Limit the safe point scope in WorkerThreadableLoader to the actual safe point. (Closed)

Created:
6 years, 9 months ago by Mads Ager (chromium)
Modified:
6 years, 9 months ago
CC:
blink-reviews, Nate Chapin, gavinp+loader_chromium.org
Visibility:
Public.

Description

Limit the safe point scope in WorkerThreadableLoader to the actual safe point. clientBridgePtr->run() can allocate and is therefore not part of the safe point. TBR=haraken@chromium.org, vegorov@chromium.org NOTRY=true BUG=356307 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=170058

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -5 lines) Patch
M Source/core/loader/WorkerThreadableLoader.cpp View 1 chunk +7 lines, -5 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Mads Ager (chromium)
6 years, 9 months ago (2014-03-26 14:04:14 UTC) #1
Mads Ager (chromium)
The CQ bit was checked by ager@chromium.org
6 years, 9 months ago (2014-03-26 14:04:54 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ager@chromium.org/212573005/1
6 years, 9 months ago (2014-03-26 14:04:58 UTC) #3
commit-bot: I haz the power
Change committed as 170058
6 years, 9 months ago (2014-03-26 14:05:14 UTC) #4
haraken
LGTM
6 years, 9 months ago (2014-03-26 14:05:28 UTC) #5
zerny-chromium
lgtm
6 years, 9 months ago (2014-03-26 14:05:51 UTC) #6
wibling-chromium
6 years, 9 months ago (2014-03-26 14:08:05 UTC) #7
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698