Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Issue 212573002: Reland "ARM64: Add overflow checking support for multiplications by constant powers of 2." (Closed)

Created:
6 years, 9 months ago by Alexandre Rames
Modified:
6 years, 9 months ago
CC:
v8-dev
Visibility:
Public.

Description

Reland "ARM64: Add overflow checking support for multiplications by constant powers of 2." This includes fixes for the overflow case spotted in mjsunit/mul-exhaustive-part4. R=ulan@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=20267

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+52 lines, -23 lines) Patch
M src/arm64/lithium-arm64.cc View 1 chunk +15 lines, -8 lines 0 comments Download
M src/arm64/lithium-codegen-arm64.cc View 4 chunks +37 lines, -15 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Alexandre Rames
Created a new issue for the re-land.
6 years, 9 months ago (2014-03-26 09:57:30 UTC) #1
ulan
lgtm, thanks for fixing it!
6 years, 9 months ago (2014-03-26 10:00:54 UTC) #2
Alexandre Rames
6 years, 9 months ago (2014-03-26 10:11:09 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r20267 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698