Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(670)

Issue 2125703005: [gn] Fix config for using clang (Closed)

Created:
4 years, 5 months ago by Michael Achenbach
Modified:
4 years, 5 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[gn] Fix config for using clang Needed for https://codereview.chromium.org/2124263002/ BUG=chromium:474921 TBR=jochen@chromium.org, vogelheim@chromium.org, NOTRY=true Committed: https://crrev.com/03453d10be08a04ce99be1836cf91eee8ba9eca6 Cr-Commit-Position: refs/heads/master@{#37574}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -5 lines) Patch
M infra/mb/mb_config.pyl View 5 chunks +5 lines, -5 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
Michael Achenbach
TBR - the correct arg is is_clang. There are probably a few more like this. ...
4 years, 5 months ago (2016-07-07 08:59:18 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2125703005/1
4 years, 5 months ago (2016-07-07 09:00:30 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-07 09:02:44 UTC) #7
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/03453d10be08a04ce99be1836cf91eee8ba9eca6 Cr-Commit-Position: refs/heads/master@{#37574}
4 years, 5 months ago (2016-07-07 09:05:04 UTC) #9
vogelheim
4 years, 5 months ago (2016-07-07 10:59:30 UTC) #10
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698