Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(124)

Issue 2125693002: Move removing keyIdentifier to M54. (Closed)

Created:
4 years, 5 months ago by dtapuska
Modified:
4 years, 5 months ago
Reviewers:
Rick Byers
CC:
chromium-reviews, blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move removing keyIdentifier to M54. I didn't get the changes done in time and we will land it in m54. This change is itended to update the mesage in M53 release. BUG=625854 Committed: https://crrev.com/914730efebf6de6519c88ae9277d06e732a24ad0 Cr-Commit-Position: refs/heads/master@{#403815}

Patch Set 1 #

Patch Set 2 : Fix layout tests #

Messages

Total messages: 19 (10 generated)
dtapuska
Simple review :-)
4 years, 5 months ago (2016-07-05 15:49:20 UTC) #3
Rick Byers
LGTM
4 years, 5 months ago (2016-07-05 15:50:11 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2125693002/1
4 years, 5 months ago (2016-07-05 15:54:37 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/250301)
4 years, 5 months ago (2016-07-05 16:38:20 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2125693002/20001
4 years, 5 months ago (2016-07-05 16:51:10 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/257378)
4 years, 5 months ago (2016-07-05 18:23:06 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2125693002/20001
4 years, 5 months ago (2016-07-05 18:25:29 UTC) #15
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 5 months ago (2016-07-05 19:36:55 UTC) #17
commit-bot: I haz the power
4 years, 5 months ago (2016-07-05 19:38:15 UTC) #19
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/914730efebf6de6519c88ae9277d06e732a24ad0
Cr-Commit-Position: refs/heads/master@{#403815}

Powered by Google App Engine
This is Rietveld 408576698