Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(143)

Unified Diff: content/browser/media/session/pepper_playback_observer.cc

Issue 2125633003: Adding UMA to record whether Pepper players have ever played sound (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: nit Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/browser/media/session/pepper_playback_observer.h ('k') | tools/metrics/histograms/histograms.xml » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/media/session/pepper_playback_observer.cc
diff --git a/content/browser/media/session/pepper_playback_observer.cc b/content/browser/media/session/pepper_playback_observer.cc
index 3db9298a1f135f6370dce30a560e4e04268b1260..9411b7fe7a249e0975051b195ca597302204f34e 100644
--- a/content/browser/media/session/pepper_playback_observer.cc
+++ b/content/browser/media/session/pepper_playback_observer.cc
@@ -5,6 +5,7 @@
#include "content/browser/media/session/pepper_playback_observer.h"
#include "base/feature_list.h"
+#include "base/metrics/histogram_macros.h"
#include "content/browser/media/session/media_session.h"
#include "content/browser/media/session/pepper_player_delegate.h"
#include "content/common/frame_messages.h"
@@ -30,13 +31,20 @@ PepperPlaybackObserver::~PepperPlaybackObserver() {
}
void PepperPlaybackObserver::PepperInstanceCreated(int32_t pp_instance) {
+ players_played_sound_map_[pp_instance] = false;
}
void PepperPlaybackObserver::PepperInstanceDeleted(int32_t pp_instance) {
+ UMA_HISTOGRAM_BOOLEAN("Media.Pepper.PlayedSound",
+ players_played_sound_map_[pp_instance]);
+ players_played_sound_map_.erase(pp_instance);
+
PepperStopsPlayback(pp_instance);
}
void PepperPlaybackObserver::PepperStartsPlayback(int32_t pp_instance) {
+ players_played_sound_map_[pp_instance] = true;
+
if (!base::FeatureList::IsEnabled(media::kFlashJoinsMediaSession))
return;
« no previous file with comments | « content/browser/media/session/pepper_playback_observer.h ('k') | tools/metrics/histograms/histograms.xml » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698