Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(866)

Unified Diff: third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/builder_list.py

Issue 2125633002: Fill out implementation of UpdateTestExpectations script (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@updateTestExpectations2
Patch Set: Quinten's Review Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/layout_package/bot_test_expectations.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/builder_list.py
diff --git a/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/builder_list.py b/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/builder_list.py
index 617f5874c4b43eeb080369e3de9f5732d8213846..8fbec506e22dc6942d83fb41ad61a3b7e7392dc4 100644
--- a/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/builder_list.py
+++ b/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/builder_list.py
@@ -42,8 +42,8 @@ class BuilderList(object):
The given dictionary maps builder names to dicts with the keys:
"port_name": A fully qualified port name.
"specifiers": TestExpectations specifiers for that config. Valid values are found in
- TestExpectationsParser._configuration_tokens_list.
- "is_try_builder": True for try bots, False for continuous waterfall builders.
+ TestExpectationsParser._configuration_tokens_list. specifiers is a list whose
+ first item is the version string and second item is the build type.
Possible refactoring note: Potentially, it might make sense to use
webkitpy.common.buildbot.Builder and add port_name and specifiers
@@ -86,3 +86,17 @@ class BuilderList(object):
else:
return builder_name
return debug_builder_name
+
+ def builder_name_for_specifiers(self, version, build_type):
+ """Returns the builder name for a give version and build type.
+
+ Args:
+ version: A string with the OS version specifier. e.g. "win7", "precise", "mac10.10".
+ build_type: A string with the build type. e.g. "debug" or "release".
+ """
+ for builder_name, info in sorted(self._builders.items()):
+ specifiers = info['specifiers']
+ if specifiers[0].lower() == version.lower() and specifiers[1].lower() == build_type.lower():
+ return builder_name
+
+ return ''
« no previous file with comments | « no previous file | third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/layout_package/bot_test_expectations.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698