Fill out implementation of UpdateTestExpectations script

third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/layout_package/bot_test_expectations.py

 # Copyright (C) 2013 Google Inc. All rights reserved.
 #
 # Redistribution and use in source and binary forms, with or without
 # modification, are permitted provided that the following conditions are
 # met:
 #
 #     * Redistributions of source code must retain the above copyright
 # notice, this list of conditions and the following disclaimer.
 #     * Redistributions in binary form must reproduce the above
 # copyright notice, this list of conditions and the following disclaimer
@@ skipping 91 matching lines @@
     def expectation_for_type(self, type_char):
         return self._json[self.builder_name][self.FAILURE_MAP_KEY][type_char]
 
     # Knowing how to parse the run-length-encoded values in results.json
     # is a detail of this class.
     def occurances_and_type_from_result_item(self, item):
         return item[self.RLE_LENGTH], item[self.RLE_VALUE]
 
 
 class BotTestExpectationsFactory(object):
     RESULTS_URL_PREFIX = 'http://test-results.appspot.com/testfile?master=ChromiumWebkit&testtype=webkit_tests&name=results-small.json&builder='

[qyearsley, 2016/07/08 17:55:03]

Question, unrelated to this CL:

Do you know where "results.json" is produced and uploaded and used? It looks
like it's used and stored by test-results.appspot.com (
http://test-results.appspot.com/testfile), but not output directly by
run-webkit-tests.

[bokan, 2016/07/08 21:12:59]

Sorry, I don't. Ojan or someone more familiar with this code might know.

 
     def __init__(self, builders):
         self.builders = builders
 
     def _results_json_for_port(self, port_name, builder_category):
         builder = self.builders.builder_name_for_port_name(port_name)
         if not builder:
             return None
         return self._results_json_for_builder(builder)
 
@@ skipping 97 matching lines @@
             additional_expectations = set(e for e in result_exp if not expected(e))
 
             # Test did not have unexpected results.
             if not additional_expectations:
                 continue
 
             expectations.update(additional_expectations)
             unexpected_results_by_path[test_path] = sorted(map(exp_to_string, expectations))
         return unexpected_results_by_path
 
+    def all_results_by_path(self):
+        results_by_path = {}
+        for test_path, entry in self.results_json.walk_results():
+            results_dict = entry.get(self.results_json.RESULTS_KEY, {})
+
+            result_types = self._all_types_in_results(results_dict)
+
+            if not result_types:
+                continue
+
+            # Distinct results as non-encoded strings.

[qyearsley, 2016/07/08 17:55:03]

Besides this comment, there are a couple ways that I think this could be made
clearer:

1. Add a simple unit test for this method with example output.
2. Add a docstring saying something like "Returns a dict mapping test paths to
lists of to non-encoded result strings (e.g. "TEXT", "CRASH", "PASS").

[bokan, 2016/07/08 21:13:00]

Done.

+            result_strings = map(self.results_json.expectation_for_type, result_types)
+
+            results_by_path[test_path] = sorted(result_strings)
+        return results_by_path
+
     def expectation_lines(self, only_ignore_very_flaky):
         lines = []
         for test_path, entry in self.results_json.walk_results():
             flaky_types = self._flaky_types_in_results(entry, only_ignore_very_flaky)
             if len(flaky_types) > 1:
                 line = self._line_from_test_and_flaky_types(test_path, flaky_types)
                 lines.append(line)
         return lines
 
     def _all_types_in_results(self, run_length_encoded_results):
@@ skipping 56 matching lines @@
                 # The only thing we lose by not fixing this is that a test that was flaky
                 # and got fixed will still get printed out until 100 runs have passed.
                 if not TestExpectations.result_was_expected(result_enum, latest_expectations, test_needs_rebaselining=False):
                     has_unexpected_results = True
                     break
 
             if has_unexpected_results:
                 flaky_results = flaky_results.union(set(result_types))
 
         return flaky_results