Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Issue 212563009: Lazy image decoding to reduce bench_record overhead. (Closed)

Created:
6 years, 9 months ago by mtklein_C
Modified:
6 years, 8 months ago
CC:
skia-review_googlegroups.com
Base URL:
https://skia.googlesource.com/skia.git@master
Visibility:
Public.

Description

Lazy image decoding to reduce bench_record overhead. We want bench_record to time recording only, and are willing to accept some time spent playing back the source pictures only out of necessity. This lets us skip the JPEG and PNG decoding, which are a pretty fair chunk of time. Should mean better record numbers at the same --loops. BUG=skia: Committed: http://code.google.com/p/skia/source/detail?r=13977

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -3 lines) Patch
M gyp/tools.gyp View 1 chunk +9 lines, -2 lines 0 comments Download
M tools/bench_record.cpp View 2 chunks +3 lines, -1 line 0 comments Download

Messages

Total messages: 8 (0 generated)
mtklein_C
6 years, 9 months ago (2014-03-26 16:01:50 UTC) #1
mtklein
+Hal
6 years, 9 months ago (2014-03-28 15:00:37 UTC) #2
hal.canary
lgtm
6 years, 9 months ago (2014-03-28 15:04:37 UTC) #3
mtklein
The CQ bit was checked by mtklein@google.com
6 years, 9 months ago (2014-03-28 15:04:45 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/mtklein@chromium.org/212563009/1
6 years, 9 months ago (2014-03-28 15:04:52 UTC) #5
commit-bot: I haz the power
Change committed as 13977
6 years, 9 months ago (2014-03-28 16:08:29 UTC) #6
tomhudson
Wanted: gmail filter guru to fix my filters so review requests like this don't show ...
6 years, 8 months ago (2014-03-31 12:21:16 UTC) #7
mtklein
6 years, 8 months ago (2014-03-31 14:48:43 UTC) #8
Message was sent while issue was closed.
On 2014/03/31 12:21:16, tomhudson wrote:
> Wanted: gmail filter guru to fix my filters so review requests like this don't
> show up at the bottom of a trivial folder instead of the top of my priority
> inbox.

I have to:me and from:me labels and filters.  So my inbox list looks like

Inbox (24)
Starred
from:me (1)
to:me (8)
More ...

Powered by Google App Engine
This is Rietveld 408576698